Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 119613004: DevTools: Add MutationObserver instrumentation for async stacks tracking. (Closed)

Created:
6 years, 12 months ago by aandrey
Modified:
6 years, 12 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, sof, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

DevTools: Add MutationObserver instrumentation for async stacks tracking. Bind async call stack for a MutationCallback call to the first point in the code that enqueued a MutationRecord into a given MutationObserver instance. For example, while paused in a MutationObserver callback, we will show an async call stack pointing to the earliest place in the code where one of the received DOM mutations happened (usually the first one). BUG=272416 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164358

Patch Set 1 #

Patch Set 2 : safer #

Patch Set 3 : instrumentation call from the ~MutationObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -0 lines) Patch
A LayoutTests/inspector/debugger/async-callstack-mutation-observer.html View 1 chunk +95 lines, -0 lines 0 comments Download
A LayoutTests/inspector/debugger/async-callstack-mutation-observer-expected.txt View 1 chunk +73 lines, -0 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 2 5 chunks +8 lines, -0 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 3 chunks +48 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aandrey
6 years, 12 months ago (2013-12-25 08:01:24 UTC) #1
yurys
lgtm
6 years, 12 months ago (2013-12-27 09:29:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/119613004/60001
6 years, 12 months ago (2013-12-27 09:38:45 UTC) #3
commit-bot: I haz the power
6 years, 12 months ago (2013-12-27 11:42:08 UTC) #4
Message was sent while issue was closed.
Change committed as 164358

Powered by Google App Engine
This is Rietveld 408576698