Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 11961051: Merge 176816 (Closed)

Created:
7 years, 11 months ago by Chris Evans
Modified:
7 years, 11 months ago
Reviewers:
sheu
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Merge 176816 > Enforce non-negative BitstreamBuffer id > > There is some video decode accelerator code that assumes that a negative > BitstreamBuffer id is never given, and uses it to mark error conditions. > > * Check for non-negative id when receving over IPC. > * Make sure we don't send negative ids from our video decode pipeline (by > handling wrapping) > * Update PPAPI interface to document the fact that negative ids should not > be used. > > BUG=chromium:168293 > TEST=local build, run on snow > > > Review URL: https://chromiumcodereview.appspot.com/11826064 TBR=sheu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/api/dev/pp_video_dev.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/c/dev/pp_video_dev.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Evans
7 years, 11 months ago (2013-01-17 21:35:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698