Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: runtime/vm/intermediate_language.h

Issue 11961041: Fix use of uninitialized memory in debug assert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: +comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 2ed304cf11490b7aa7aa90ed43f814d16f796165..98f94baf93478fc293b9b39ba71b3c0a7841e245 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -2284,9 +2284,10 @@ class EqualityCompareInstr : public ComparisonInstr {
Value* left,
Value* right)
: ComparisonInstr(kind, left, right),
- ic_data_(Isolate::Current()->GetICDataForDeoptId(deopt_id())),
token_pos_(token_pos),
receiver_class_id_(kIllegalCid) {
+ // deopt_id() checks receiver_class_id_ value.
+ ic_data_ = Isolate::Current()->GetICDataForDeoptId(deopt_id());
ASSERT((kind == Token::kEQ) || (kind == Token::kNE));
}
@@ -2351,9 +2352,10 @@ class RelationalOpInstr : public ComparisonInstr {
Value* left,
Value* right)
: ComparisonInstr(kind, left, right),
- ic_data_(Isolate::Current()->GetICDataForDeoptId(deopt_id())),
token_pos_(token_pos),
operands_class_id_(kIllegalCid) {
+ // deopt_id() checks operands_class_id_ value.
+ ic_data_ = Isolate::Current()->GetICDataForDeoptId(deopt_id());
ASSERT(Token::IsRelationalOperator(kind));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698