Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 11961037: Add assertion to check that CPU profiling actually works. (Closed)

Created:
7 years, 11 months ago by eustas
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
caseq
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Recently I tried to debug CPU profiling on Chrome. I've found that profiling is not working in Debug version. The actual problem is that sandbox/playgroung configuration is wrong and tgkill syscalls are disallowed. This patch will make such cases more clear. Committed: http://code.google.com/p/v8/source/detail?r=13411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/platform-linux.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eustas
7 years, 11 months ago (2013-01-17 09:00:19 UTC) #1
Jakob Kummerow
LGTM, landing. I'm not quite convinced that crashing by means of a failing ASSERT is ...
7 years, 11 months ago (2013-01-17 13:46:12 UTC) #2
caseq1
7 years, 11 months ago (2013-01-17 13:56:28 UTC) #3
Message was sent while issue was closed.
On 2013/01/17 13:46:12, Jakob wrote:

> I'm not quite convinced that crashing by means of a failing ASSERT is the best
> reaction when requesting a profiling tick fails (as opposed to, say, printing
a
> warning); but we can always change that if this behavior turns out to be
> annoying.

Well, judging by possible result codes in tgkill(2), it can only fail if either
argument is invalid or we don't have permission. Either case seems like a
fundamental violation of our expectations, so I think it justifies the assert.

Powered by Google App Engine
This is Rietveld 408576698