Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/sync/sync_prefs_unittest.cc

Issue 11961030: [Sync] Make SESSIONS an implicit type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_prefs.h" 5 #include "chrome/browser/sync/sync_prefs.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/time.h" 8 #include "base/time.h"
9 #include "chrome/test/base/testing_pref_service.h" 9 #include "chrome/test/base/testing_pref_service.h"
10 #include "sync/internal_api/public/base/model_type.h" 10 #include "sync/internal_api/public/base/model_type.h"
(...skipping 21 matching lines...) Expand all
32 32
33 // Returns all types visible from the setup UI. 33 // Returns all types visible from the setup UI.
34 syncer::ModelTypeSet GetUserVisibleTypes() { 34 syncer::ModelTypeSet GetUserVisibleTypes() {
35 syncer::ModelTypeSet user_visible_types(syncer::UserTypes()); 35 syncer::ModelTypeSet user_visible_types(syncer::UserTypes());
36 user_visible_types.Remove(syncer::APP_NOTIFICATIONS); 36 user_visible_types.Remove(syncer::APP_NOTIFICATIONS);
37 user_visible_types.Remove(syncer::APP_SETTINGS); 37 user_visible_types.Remove(syncer::APP_SETTINGS);
38 user_visible_types.Remove(syncer::AUTOFILL_PROFILE); 38 user_visible_types.Remove(syncer::AUTOFILL_PROFILE);
39 user_visible_types.Remove(syncer::DICTIONARY); 39 user_visible_types.Remove(syncer::DICTIONARY);
40 user_visible_types.Remove(syncer::EXTENSION_SETTINGS); 40 user_visible_types.Remove(syncer::EXTENSION_SETTINGS);
41 user_visible_types.Remove(syncer::SEARCH_ENGINES); 41 user_visible_types.Remove(syncer::SEARCH_ENGINES);
42 user_visible_types.Remove(syncer::SESSIONS);
43 user_visible_types.Remove(syncer::HISTORY_DELETE_DIRECTIVES);
42 return user_visible_types; 44 return user_visible_types;
43 } 45 }
44 46
45 TEST_F(SyncPrefsTest, Basic) { 47 TEST_F(SyncPrefsTest, Basic) {
46 SyncPrefs sync_prefs(&pref_service_); 48 SyncPrefs sync_prefs(&pref_service_);
47 49
48 EXPECT_FALSE(sync_prefs.HasSyncSetupCompleted()); 50 EXPECT_FALSE(sync_prefs.HasSyncSetupCompleted());
49 sync_prefs.SetSyncSetupCompleted(); 51 sync_prefs.SetSyncSetupCompleted();
50 EXPECT_TRUE(sync_prefs.HasSyncSetupCompleted()); 52 EXPECT_TRUE(sync_prefs.HasSyncSetupCompleted());
51 53
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 expected_preferred_types.Put(syncer::DICTIONARY); 113 expected_preferred_types.Put(syncer::DICTIONARY);
112 expected_preferred_types.Put(syncer::SEARCH_ENGINES); 114 expected_preferred_types.Put(syncer::SEARCH_ENGINES);
113 } 115 }
114 if (it.Get() == syncer::APPS) { 116 if (it.Get() == syncer::APPS) {
115 expected_preferred_types.Put(syncer::APP_NOTIFICATIONS); 117 expected_preferred_types.Put(syncer::APP_NOTIFICATIONS);
116 expected_preferred_types.Put(syncer::APP_SETTINGS); 118 expected_preferred_types.Put(syncer::APP_SETTINGS);
117 } 119 }
118 if (it.Get() == syncer::EXTENSIONS) { 120 if (it.Get() == syncer::EXTENSIONS) {
119 expected_preferred_types.Put(syncer::EXTENSION_SETTINGS); 121 expected_preferred_types.Put(syncer::EXTENSION_SETTINGS);
120 } 122 }
121 if (it.Get() == syncer::SESSIONS) { 123 if (it.Get() == syncer::TYPED_URLS) {
122 expected_preferred_types.Put(syncer::HISTORY_DELETE_DIRECTIVES); 124 expected_preferred_types.Put(syncer::HISTORY_DELETE_DIRECTIVES);
125 expected_preferred_types.Put(syncer::SESSIONS);
123 } 126 }
124 // TODO(akalin): Remove this when history delete directives are 127 if (it.Get() == syncer::TABS) {
125 // registered by default. 128 expected_preferred_types.Put(syncer::SESSIONS);
126 if (it.Get() == syncer::HISTORY_DELETE_DIRECTIVES) {
127 expected_preferred_types.Clear();
128 } 129 }
129 sync_prefs.SetPreferredDataTypes(user_types, preferred_types); 130 sync_prefs.SetPreferredDataTypes(user_types, preferred_types);
130 EXPECT_TRUE(expected_preferred_types.Equals( 131 EXPECT_TRUE(expected_preferred_types.Equals(
131 sync_prefs.GetPreferredDataTypes(user_types))); 132 sync_prefs.GetPreferredDataTypes(user_types)));
132 } 133 }
133 } 134 }
134 135
135 class MockSyncPrefObserver : public SyncPrefObserver { 136 class MockSyncPrefObserver : public SyncPrefObserver {
136 public: 137 public:
137 MOCK_METHOD1(OnSyncManagedPrefChange, void(bool)); 138 MOCK_METHOD1(OnSyncManagedPrefChange, void(bool));
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 EXPECT_FALSE(sync_prefs.HasKeepEverythingSynced()); 204 EXPECT_FALSE(sync_prefs.HasKeepEverythingSynced());
204 const syncer::ModelTypeSet user_types = syncer::UserTypes(); 205 const syncer::ModelTypeSet user_types = syncer::UserTypes();
205 EXPECT_TRUE(sync_prefs.GetPreferredDataTypes(user_types).Empty()); 206 EXPECT_TRUE(sync_prefs.GetPreferredDataTypes(user_types).Empty());
206 EXPECT_FALSE(sync_prefs.IsManaged()); 207 EXPECT_FALSE(sync_prefs.IsManaged());
207 EXPECT_TRUE(sync_prefs.GetEncryptionBootstrapToken().empty()); 208 EXPECT_TRUE(sync_prefs.GetEncryptionBootstrapToken().empty());
208 } 209 }
209 210
210 } // namespace 211 } // namespace
211 212
212 } // namespace browser_sync 213 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698