Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: chrome/browser/sync/sync_prefs_unittest.cc

Issue 11961030: [Sync] Make SESSIONS an implicit type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_prefs.h" 5 #include "chrome/browser/sync/sync_prefs.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/time.h" 8 #include "base/time.h"
9 #include "chrome/test/base/testing_pref_service.h" 9 #include "chrome/test/base/testing_pref_service.h"
10 #include "sync/internal_api/public/base/model_type.h" 10 #include "sync/internal_api/public/base/model_type.h"
(...skipping 20 matching lines...) Expand all
31 }; 31 };
32 32
33 // Returns all types visible from the setup UI. 33 // Returns all types visible from the setup UI.
34 syncer::ModelTypeSet GetUserVisibleTypes() { 34 syncer::ModelTypeSet GetUserVisibleTypes() {
35 syncer::ModelTypeSet user_visible_types(syncer::UserTypes()); 35 syncer::ModelTypeSet user_visible_types(syncer::UserTypes());
36 user_visible_types.Remove(syncer::APP_NOTIFICATIONS); 36 user_visible_types.Remove(syncer::APP_NOTIFICATIONS);
37 user_visible_types.Remove(syncer::APP_SETTINGS); 37 user_visible_types.Remove(syncer::APP_SETTINGS);
38 user_visible_types.Remove(syncer::AUTOFILL_PROFILE); 38 user_visible_types.Remove(syncer::AUTOFILL_PROFILE);
39 user_visible_types.Remove(syncer::EXTENSION_SETTINGS); 39 user_visible_types.Remove(syncer::EXTENSION_SETTINGS);
40 user_visible_types.Remove(syncer::SEARCH_ENGINES); 40 user_visible_types.Remove(syncer::SEARCH_ENGINES);
41 user_visible_types.Remove(syncer::SESSIONS);
42 user_visible_types.Remove(syncer::HISTORY_DELETE_DIRECTIVES);
41 return user_visible_types; 43 return user_visible_types;
42 } 44 }
43 45
44 TEST_F(SyncPrefsTest, Basic) { 46 TEST_F(SyncPrefsTest, Basic) {
45 SyncPrefs sync_prefs(&pref_service_); 47 SyncPrefs sync_prefs(&pref_service_);
46 48
47 EXPECT_FALSE(sync_prefs.HasSyncSetupCompleted()); 49 EXPECT_FALSE(sync_prefs.HasSyncSetupCompleted());
48 sync_prefs.SetSyncSetupCompleted(); 50 sync_prefs.SetSyncSetupCompleted();
49 EXPECT_TRUE(sync_prefs.HasSyncSetupCompleted()); 51 EXPECT_TRUE(sync_prefs.HasSyncSetupCompleted());
50 52
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 if (it.Get() == syncer::PREFERENCES) { 111 if (it.Get() == syncer::PREFERENCES) {
110 expected_preferred_types.Put(syncer::SEARCH_ENGINES); 112 expected_preferred_types.Put(syncer::SEARCH_ENGINES);
111 } 113 }
112 if (it.Get() == syncer::APPS) { 114 if (it.Get() == syncer::APPS) {
113 expected_preferred_types.Put(syncer::APP_NOTIFICATIONS); 115 expected_preferred_types.Put(syncer::APP_NOTIFICATIONS);
114 expected_preferred_types.Put(syncer::APP_SETTINGS); 116 expected_preferred_types.Put(syncer::APP_SETTINGS);
115 } 117 }
116 if (it.Get() == syncer::EXTENSIONS) { 118 if (it.Get() == syncer::EXTENSIONS) {
117 expected_preferred_types.Put(syncer::EXTENSION_SETTINGS); 119 expected_preferred_types.Put(syncer::EXTENSION_SETTINGS);
118 } 120 }
119 if (it.Get() == syncer::SESSIONS) { 121 if (it.Get() == syncer::TYPED_URLS) {
120 expected_preferred_types.Put(syncer::HISTORY_DELETE_DIRECTIVES); 122 expected_preferred_types.Put(syncer::HISTORY_DELETE_DIRECTIVES);
123 expected_preferred_types.Put(syncer::SESSIONS);
121 } 124 }
122 // TODO(akalin): Remove this when history delete directives are 125 if (it.Get() == syncer::TABS) {
123 // registered by default. 126 expected_preferred_types.Put(syncer::SESSIONS);
124 if (it.Get() == syncer::HISTORY_DELETE_DIRECTIVES) {
125 expected_preferred_types.Clear();
126 } 127 }
127 sync_prefs.SetPreferredDataTypes(user_types, preferred_types); 128 sync_prefs.SetPreferredDataTypes(user_types, preferred_types);
128 EXPECT_TRUE(expected_preferred_types.Equals( 129 EXPECT_TRUE(expected_preferred_types.Equals(
129 sync_prefs.GetPreferredDataTypes(user_types))); 130 sync_prefs.GetPreferredDataTypes(user_types)));
130 } 131 }
131 } 132 }
132 133
133 class MockSyncPrefObserver : public SyncPrefObserver { 134 class MockSyncPrefObserver : public SyncPrefObserver {
134 public: 135 public:
135 MOCK_METHOD1(OnSyncManagedPrefChange, void(bool)); 136 MOCK_METHOD1(OnSyncManagedPrefChange, void(bool));
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 EXPECT_FALSE(sync_prefs.HasKeepEverythingSynced()); 202 EXPECT_FALSE(sync_prefs.HasKeepEverythingSynced());
202 const syncer::ModelTypeSet user_types = syncer::UserTypes(); 203 const syncer::ModelTypeSet user_types = syncer::UserTypes();
203 EXPECT_TRUE(sync_prefs.GetPreferredDataTypes(user_types).Empty()); 204 EXPECT_TRUE(sync_prefs.GetPreferredDataTypes(user_types).Empty());
204 EXPECT_FALSE(sync_prefs.IsManaged()); 205 EXPECT_FALSE(sync_prefs.IsManaged());
205 EXPECT_TRUE(sync_prefs.GetEncryptionBootstrapToken().empty()); 206 EXPECT_TRUE(sync_prefs.GetEncryptionBootstrapToken().empty());
206 } 207 }
207 208
208 } // namespace 209 } // namespace
209 210
210 } // namespace browser_sync 211 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698