Issue 11961029: Control group

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11961029: Control group (Closed)

Created:
7 years, 11 months ago by robertphillips

Modified:
7 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Control group roll: https://codereview.chromium.org/11989002/

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/whitespace_file.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

robertphillips

7 years, 11 months ago (2013-01-17 13:23:10 UTC) #1

Despite the win_layout* bots still missing I believe this is 'good'. The
discrepancies between the roll and control are:

linux
   roll:    
            browser_tests failed 10
                SimpleTest
                DestroyWithPendingNotification
                HistorySearchXSS
                PRE_TranslateSessionRestore
                TranslateSessionRestore
                LoadNTPInExistingProcess
                URLNotInCache
                Messaging
                KillPanelExtension
                ArgumentValidation
   control: 
            unit_tests 37 disabled failed 6
                UDPEcho100BytesHasProxy
                UDPEcho100BytesNoProxy
                UDPEcho1KBytesHasProxy
                UDPEcho500BytesHasProxy
                UDPEcho500BytesNoProxy
                UDPEchoMultiplePacketsNoProxy

linux_chromeos_asan
   roll:    
            check_deps failed - java warnings - not Skia related
   control: 
            green

win
   roll:    
            interactive_ui_tests failed 2
                FocusRestore 
                OnChangeEvent
            browser_tests failed 39
                AppProcess
                OpenAppFromExtension
                ReloadIntoAppProcess
                LoginExtraNavigations
                IsInstalled
                BasicCookies
                PRE_BasicCookies
                ExecuteScriptPermissions
                CaptureVisibleNoFile
                ExceptionInHandlerShouldNotCrash
                TabEvents
                TabOpener
                TabUpdate
                UpdateWindowShowState
                ParseFeedValidFeed5
                IconsLoaded
                LaunchPanelApp
                Uninstall
                WebRequestDeclarative
                CookieIsolation
                RedirectedURLLastInWhitelist
                CrashRenderers
                CalledOnceExpectTwiceFails
                WebStoreExtension
                netInternalsHSTSViewAddOverwrite
                netInternalsTimelineViewScrollbar
                WindowsApiProperties
                TranslateEnabled
                SetPrefs
                PrerenderClientRedirectToHttpsInIframe
                WebNavigation
                TestDuplexSettingsFalse
                HttpsTargetBlankOrigin
                MiddleClickTargetBlankRedirect
                HideOnSecondClick
                History
                TestSettingsFrameStartup
                TestRuntimeErrorFailsFast
                Install
   control: 
            interactive_ui_tests failed 1
                OnChangeEvent
            content_browsertests failed 1
                Tests

mac_layout_rel
   roll:    compile failed - duplicate symbol - AudioDestinationChromium
   control: compile failed - duplicate symbol - AudioDestinationChromium

Expand Messages | Collapse Messages