Issue 11961014: Inline SetWrapperClassId() and WrapperClassId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11961014: Inline SetWrapperClassId() and WrapperClassId() (Closed)

Created:
7 years, 11 months ago by haraken

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger, danno

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Inline SetWrapperClassId() and WrapperClassId() BUG= TEST=test-api.cc (WrapperClassId) Committed: http://code.google.com/p/v8/source/detail?r=13405

Patch Set 3 : patch #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
M	include/v8.h	View		2 chunks	+9 lines, -2 lines	2 comments	Download
M	src/api.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/global-handles.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haraken

SetWrapperClassId() is in a hot call path of V8 binding. michael: would you review it?

7 years, 11 months ago (2013-01-16 12:35:06 UTC) #1

Michael Starzinger

LGTM, I'll land this for you. https://chromiumcodereview.appspot.com/11961014/diff/6001/include/v8.h File include/v8.h (left): https://chromiumcodereview.appspot.com/11961014/diff/6001/include/v8.h#oldcode3546 include/v8.h:3546: static uint16_t GetWrapperClassId(internal::Object** ...

7 years, 11 months ago (2013-01-16 15:39:12 UTC) #2

haraken

7 years, 11 months ago (2013-01-16 15:41:54 UTC) #3

https://chromiumcodereview.appspot.com/11961014/diff/6001/include/v8.h
File include/v8.h (left):

https://chromiumcodereview.appspot.com/11961014/diff/6001/include/v8.h#oldcod...
include/v8.h:3546: static uint16_t GetWrapperClassId(internal::Object**
global_handle);
Right. Thanks!

Expand Messages | Collapse Messages

Issue 11961014: Inline SetWrapperClassId() and WrapperClassId() (Closed)

Description

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Messages