Web Animations: Avoid iteration when checking for outdated animations on timeline

Source/core/animation/AnimationTimeline.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
 
 PassRefPtrWillBeRawPtr<AnimationTimeline> AnimationTimeline::create(Document* document, PassOwnPtrWillBeRawPtr<PlatformTiming> timing)
 {
     return adoptRefWillBeNoop(new AnimationTimeline(document, timing));
 }
 
 AnimationTimeline::AnimationTimeline(Document* document, PassOwnPtrWillBeRawPtr<PlatformTiming> timing)
     : m_document(document)
     , m_zeroTime(0) // 0 is used by unit tests which cannot initialize from the loader
     , m_zeroTimeInitialized(false)
+    , m_outdatedAnimationCount(0)
     , m_playbackRate(1)
     , m_lastCurrentTimeInternal(0)
 {
     if (!timing)
         m_timing = adoptPtrWillBeNoop(new AnimationTimelineTiming(this));
     else
         m_timing = timing;
 
     if (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled() && Platform::current()->compositorSupport())
         m_compositorTimeline = adoptPtr(Platform::current()->compositorSupport()->createAnimationTimeline());
@@ skipping 59 matching lines @@
     for (RefPtrWillBeMember<Animation> animation : m_animationsNeedingUpdate)
         animations.append(animation.get());
 
     std::sort(animations.begin(), animations.end(), Animation::hasLowerPriority);
 
     for (Animation* animation : animations) {
         if (!animation->update(reason))
             m_animationsNeedingUpdate.remove(animation);
     }
 
-    ASSERT(!hasOutdatedAnimation());
+    ASSERT(m_outdatedAnimationCount == 0);
+
+#if ENABLE(ASSERT)
+    for (const auto& animation : m_animationsNeedingUpdate)
+        ASSERT(!animation->outdated());
+#endif
 }
 
 void AnimationTimeline::scheduleNextService()
 {
-    ASSERT(!hasOutdatedAnimation());
+    ASSERT(m_outdatedAnimationCount == 0);
 
     double timeToNextEffect = std::numeric_limits<double>::infinity();
     for (const auto& animation : m_animationsNeedingUpdate) {
         timeToNextEffect = std::min(timeToNextEffect, animation->timeToEffectChange());
     }
 
     if (timeToNextEffect < s_minimumDelay) {
         m_timing->serviceOnNextFrame();
     } else if (timeToNextEffect != std::numeric_limits<double>::infinity()) {
         m_timing->wakeAfter(timeToNextEffect - s_minimumDelay);
@@ skipping 89 matching lines @@
     return std::isnan(time) ? 0 : time;
 }
 
 void AnimationTimeline::pauseAnimationsForTesting(double pauseTime)
 {
     for (const auto& animation : m_animationsNeedingUpdate)
         animation->pauseForTesting(pauseTime);
     serviceAnimations(TimingUpdateOnDemand);
 }
 
-bool AnimationTimeline::hasOutdatedAnimation() const
-{
-    for (const auto& animation : m_animationsNeedingUpdate) {
-        if (animation->outdated())
-            return true;
-    }
-    return false;
-}
-
 bool AnimationTimeline::needsAnimationTimingUpdate()
 {
     return m_animationsNeedingUpdate.size() && currentTimeInternal() != m_lastCurrentTimeInternal;
 }
 
+void AnimationTimeline::clearOutdatedAnimation(Animation* animation)
+{
+    ASSERT(!animation->outdated());
+    m_outdatedAnimationCount--;
+}
+
 void AnimationTimeline::setOutdatedAnimation(Animation* animation)
 {
     ASSERT(animation->outdated());
+    m_outdatedAnimationCount++;
     m_animationsNeedingUpdate.add(animation);
     if (m_document && m_document->page() && !m_document->page()->animator().isServicingAnimations())
         m_timing->serviceOnNextFrame();
 }
 
 void AnimationTimeline::setPlaybackRate(double playbackRate)
 {
     if (!document())
         return;
     double currentTime = currentTimeInternal();
@@ skipping 27 matching lines @@
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_document);
     visitor->trace(m_timing);
     visitor->trace(m_animationsNeedingUpdate);
     visitor->trace(m_animations);
 #endif
 }
 
 } // namespace