Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11960003: Cleanup: Move more recursive operation logic from FileUtilHelper to FileUtil (Closed)

Created:
7 years, 11 months ago by kinuko
Modified:
7 years, 11 months ago
Reviewers:
Lei Zhang, kmadhusu, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Move more recursive operation logic from FileUtilHelper to FileUtil - To make each FileUtil methods more well-defined - To further reduce the number of FileUtil calls (As a preparation to split recursive jobs into multiple tasks) BUG=146215 TEST=content_unittests:.*File.*,content_browsertests:FileSystemLayoutTest.Op{Copy,Move} Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178294

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : addressed comments #3 + cleanup #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -227 lines) Patch
M chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media_gallery/win/mtp_device_delegate_impl_win.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_file_util.h View 1 2 3 chunks +37 lines, -8 lines 0 comments Download
M webkit/fileapi/file_util_helper.cc View 1 2 3 4 chunks +23 lines, -68 lines 0 comments Download
M webkit/fileapi/isolated_file_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/fileapi/isolated_file_util.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M webkit/fileapi/local_file_util.h View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/fileapi/local_file_util.cc View 4 chunks +8 lines, -13 lines 0 comments Download
M webkit/fileapi/media/device_media_file_util.h View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/fileapi/media/device_media_file_util.cc View 1 2 2 chunks +1 line, -19 lines 0 comments Download
M webkit/fileapi/media/native_media_file_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/fileapi/media/native_media_file_util.cc View 1 2 3 chunks +22 lines, -19 lines 0 comments Download
M webkit/fileapi/native_file_util.h View 2 chunks +12 lines, -3 lines 0 comments Download
M webkit/fileapi/native_file_util.cc View 2 chunks +25 lines, -14 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 7 chunks +40 lines, -35 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 6 chunks +8 lines, -11 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kinuko
7 years, 11 months ago (2013-01-17 16:55:24 UTC) #1
kinuko
Can you take a look?
7 years, 11 months ago (2013-01-21 04:07:22 UTC) #2
tzik
https://codereview.chromium.org/11960003/diff/10004/webkit/fileapi/file_util_helper.cc File webkit/fileapi/file_util_helper.cc (right): https://codereview.chromium.org/11960003/diff/10004/webkit/fileapi/file_util_helper.cc#newcode125 webkit/fileapi/file_util_helper.cc:125: (error != base::PLATFORM_FILE_OK && can we drop this? https://codereview.chromium.org/11960003/diff/10004/webkit/fileapi/media/device_media_file_util.cc ...
7 years, 11 months ago (2013-01-21 07:10:41 UTC) #3
kinuko
Updated. https://codereview.chromium.org/11960003/diff/10004/webkit/fileapi/file_util_helper.cc File webkit/fileapi/file_util_helper.cc (right): https://codereview.chromium.org/11960003/diff/10004/webkit/fileapi/file_util_helper.cc#newcode125 webkit/fileapi/file_util_helper.cc:125: (error != base::PLATFORM_FILE_OK && On 2013/01/21 07:10:41, tzik ...
7 years, 11 months ago (2013-01-21 07:57:54 UTC) #4
kinuko
Lei, can you take a look at the changes in: webkit/fileapi/media/ chrome/browser/media_gallery/
7 years, 11 months ago (2013-01-21 14:09:12 UTC) #5
kinuko
thestig@ or kmadhusu@ can you review changes in: > webkit/fileapi/media/ > chrome/browser/media_gallery/ tzik@, can you ...
7 years, 11 months ago (2013-01-23 03:28:19 UTC) #6
Lei Zhang
On 2013/01/21 14:09:12, kinuko wrote: > Lei, can you take a look at the changes ...
7 years, 11 months ago (2013-01-23 07:14:25 UTC) #7
tzik
lgtm
7 years, 11 months ago (2013-01-23 11:37:02 UTC) #8
kinuko
On 2013/01/23 11:37:02, tzik wrote: > lgtm Thanks!
7 years, 11 months ago (2013-01-23 11:37:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/11960003/37004
7 years, 11 months ago (2013-01-23 11:48:28 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 15:13:09 UTC) #11
Message was sent while issue was closed. 
Change committed as 178294

Powered by Google App Engine
This is Rietveld 408576698