Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1195983002: [es6] Bound function names (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Bound function names https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind Bound functions should have a name based on the function that was bound. This reverts the revert f2747ed9b48d0e62c7a30da69825ff926aeedbd2. The original CL was reverted because the Blink layout test broke. I have a CL that disables these tests at: https://codereview.chromium.org/1196753003/ BUG=N LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/b6d950c979f4348138de0ec54e40dcc48d833926 Cr-Commit-Position: refs/heads/master@{#29193}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/v8natives.js View 2 chunks +5 lines, -0 lines 1 comment Download
A test/mjsunit/function-bind-name.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-19 22:13:15 UTC) #1
adamk
lgtm Can you say a little bit more in the CL description about why you're ...
5 years, 6 months ago (2015-06-19 22:17:16 UTC) #2
arv (Not doing code reviews)
On 2015/06/19 22:17:16, adamk wrote: > lgtm > > Can you say a little bit ...
5 years, 6 months ago (2015-06-19 22:40:50 UTC) #3
adamk
Thanks, still lgtm
5 years, 6 months ago (2015-06-19 22:41:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195983002/1
5 years, 6 months ago (2015-06-19 22:42:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/67688)
5 years, 6 months ago (2015-06-19 22:54:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195983002/1
5 years, 6 months ago (2015-06-22 13:47:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 14:29:58 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6d950c979f4348138de0ec54e40dcc48d833926 Cr-Commit-Position: refs/heads/master@{#29193}
5 years, 6 months ago (2015-06-22 14:30:11 UTC) #12
Toon Verwaest
https://codereview.chromium.org/1195983002/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/1195983002/diff/1/src/v8natives.js#newcode1770 src/v8natives.js:1770: SetFunctionName(result, bound_name, "bound"); This does not work since it ...
5 years, 5 months ago (2015-07-06 15:23:00 UTC) #14
arv (Not doing code reviews)
5 years, 5 months ago (2015-07-06 15:25:12 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1225793002/ by arv@chromium.org.

The reason for reverting is: Incorrect behavior.

Powered by Google App Engine
This is Rietveld 408576698