Removing getBackingTextureImage from ImageBufferSurface

Removing getBackingTextureImage from ImageBufferSurface

This is a rehash of r197654

BUG=499001
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197669

[Justin Novosad, 2015-06-23 15:34:39]

junov@chromium.org changed reviewers:
+ fmalita@chromium.org, reed@chromium.org

[Justin Novosad, 2015-06-23 15:34:40]

Florin, I think I l-g-t-m'ed your patch too quickly. After a closer look, here
is what I think we should do.

[f(malita), 2015-06-23 15:41:16]

On 2015/06/23 at 15:34:40, junov wrote:
> Florin, I think I l-g-t-m'ed your patch too quickly. After a closer look, here
is what I think we should do.

Looks much cleaner - LGTM!

(% AcceleratedImageBufferSurface build fixes)

[Justin Novosad, 2015-06-23 15:42:51]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-06-23 15:42:51]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1195963006/#ps40001
(title: "build fix")

[commit-bot: I haz the power, 2015-06-23 15:43:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1195963006/40001

[commit-bot: I haz the power, 2015-06-23 15:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 15:50:10]

Exceeded global retry quota

[reed1, 2015-06-23 15:57:55]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-06-23 15:57:56]

https://codereview.chromium.org/1195963006/diff/40001/Source/platform/graphic...
File Source/platform/graphics/ImageBufferSurface.h (right):

https://codereview.chromium.org/1195963006/diff/40001/Source/platform/graphic...
Source/platform/graphics/ImageBufferSurface.h:85: virtual PassRefPtr<SkImage>
newImageSnapshot() const { return nullptr; }
Lets add some dox here, describing when/why it might return NULL.

are all clients of it ok to not ever force an answer (from the recording
variant)?

[Justin Novosad, 2015-06-23 17:06:15]

On 2015/06/23 15:57:56, reed1 wrote:
>
https://codereview.chromium.org/1195963006/diff/40001/Source/platform/graphic...
> File Source/platform/graphics/ImageBufferSurface.h (right):
> 
>
https://codereview.chromium.org/1195963006/diff/40001/Source/platform/graphic...
> Source/platform/graphics/ImageBufferSurface.h:85: virtual PassRefPtr<SkImage>
> newImageSnapshot() const { return nullptr; }
> Lets add some dox here, describing when/why it might return NULL.

done.
> 
> are all clients of it ok to not ever force an answer (from the recording
> variant)?

Yes. The former call sites of getBackingTextureImage() now all check
isAccelerated() first, which guarantees we are not handling a
recordingImageBufferSurface.

[Justin Novosad, 2015-06-23 17:06:55]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-06-23 17:06:55]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1195963006/#ps100001
(title: "fix unit test")

[commit-bot: I haz the power, 2015-06-23 17:07:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1195963006/100001

[commit-bot: I haz the power, 2015-06-23 19:21:07]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197669