git_common.py - Issue 1195933003: Unskip testGetBranchesInfo().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_common.py

Issue 1195933003: Unskip testGetBranchesInfo(). (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Patch v2, without extra variable in the tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_common.py

diff --git a/git_common.py b/git_common.py

index 9d9f46415a479a2c6626d078b7ac9af13ed2b946..2b7d258f60cad2c0cbfae55bd42cfa66e562a138 100644

--- a/git_common.py

+++ b/git_common.py

@@ -92,9 +92,10 @@ GIT_TRANSIENT_ERRORS = (

GIT_TRANSIENT_ERRORS_RE = re.compile('|'.join(GIT_TRANSIENT_ERRORS),

re.IGNORECASE)

-# First version where the for-each-ref command's format string supported the

-# upstream:track token.

-MIN_UPSTREAM_TRACK_GIT_VERSION = (1, 9)

+# git's for-each-ref command first supported the upstream:track token in its

+# format string in version 1.9.0, but some usages were broken until 2.3.0.

+# See git commit b6160d95 for more information.

+MIN_UPSTREAM_TRACK_GIT_VERSION = (2, 3)

class BadCommitRefException(Exception):

def __init__(self, refs):

« no previous file with comments | « no previous file | tests/git_common_test.py » ('j') | no next file with comments »