Issue 119593002: Getting rid of temporary IsGetDefaultProfileAllowed instrumentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119593002: Getting rid of temporary IsGetDefaultProfileAllowed instrumentation (Closed)

Created:
7 years ago by Mr4D (OOO till 08-26)

Modified:
7 years ago

Reviewers:
DaveMoore, sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Getting rid of temporary IsGetDefaultProfileAllowed instrumentation Getting closer to get rid of GetDefaultProfile. This is now removing the temporary instrumentation from stevenjb which was adding a check to see that GetDefaultProfile does not get called before a Profile was created. I discussed with dpolukhin and nkostylev and instead of renaming this to something like "WasProfileCreated" (or similar) the instrumentation should get removed (since it was temporary to begin with). BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242169

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -38 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/power/power_prefs_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_manager.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View	3 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/119593002/1

7 years ago (2013-12-20 18:12:18 UTC) #4

Message was sent while issue was closed.

Change committed as 242169

Expand Messages | Collapse Messages