net/proxy/proxy_resolver_perftest.cc - Issue 11959029: Make the v8 Isolate used in the proxy resolver explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_perftest.cc

Issue 11959029: Make the v8 Isolate used in the proxy resolver explicit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_perftest.cc

diff --git a/net/proxy/proxy_resolver_perftest.cc b/net/proxy/proxy_resolver_perftest.cc

index 4eae4c6cec9b5a222686f8f3ee63644f575758e4..baa305f630ca3234d70a857d461f28d85fb6bb75 100644

--- a/net/proxy/proxy_resolver_perftest.cc

+++ b/net/proxy/proxy_resolver_perftest.cc

@@ -215,10 +215,12 @@ class MockJSBindings : public net::ProxyResolverV8::JSBindings {

};

TEST(ProxyResolverPerfTest, ProxyResolverV8) {

+ // This has to be done on the main thread.

+ net::ProxyResolverV8::RememberDefaultIsolate();

MockJSBindings js_bindings;

net::ProxyResolverV8 resolver;

resolver.set_js_bindings(&js_bindings);

PacPerfSuiteRunner runner(&resolver, "ProxyResolverV8");

runner.RunAllTests();

}