Make the v8 Isolate used in the proxy resolver explicit.

chrome/browser/net/connection_tester_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/connection_tester.h"
 
 #include "chrome/test/base/testing_pref_service.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/mock_cert_verifier.h"
 #include "net/base/mock_host_resolver.h"
 #include "net/base/ssl_config_service_defaults.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/ftp/ftp_network_layer.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_server_properties_impl.h"
 #include "net/proxy/proxy_config_service_fixed.h"
 #include "net/proxy/proxy_service.h"
 #include "net/test/test_server.h"
 #include "net/url_request/url_request_context.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
+#include "v8/include/v8.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // This is a testing delegate which simply counts how many times each of
 // the delegate's methods were invoked.
 class ConnectionTesterDelegate : public ConnectionTester::Delegate {
  public:
   ConnectionTesterDelegate()
@@ skipping 109 matching lines @@
     proxy_script_fetcher_context_->set_cookie_store(
         new net::CookieMonster(NULL, NULL));
   }
 };
 
 TEST_F(ConnectionTesterTest, RunAllTests) {
   ASSERT_TRUE(test_server_.Start());
 
   ConnectionTester tester(&test_delegate_,
                           proxy_script_fetcher_context_.get(),
-                          NULL);
+                          NULL,
+                          v8::Isolate::GetCurrent());
 
   // Start the test suite on URL "echoall".
   // TODO(eroman): Is this URL right?
   tester.RunAllTests(test_server_.GetURL("echoall"));
 
   // Wait for all the tests to complete.
   MessageLoop::current()->Run();
 
   const int kNumExperiments =
       ConnectionTester::PROXY_EXPERIMENT_COUNT *
       ConnectionTester::HOST_RESOLVER_EXPERIMENT_COUNT;
 
   EXPECT_EQ(1, test_delegate_.start_connection_test_suite_count());
   EXPECT_EQ(kNumExperiments,
             test_delegate_.start_connection_test_experiment_count());
   EXPECT_EQ(kNumExperiments,
             test_delegate_.completed_connection_test_experiment_count());
   EXPECT_EQ(1, test_delegate_.completed_connection_test_suite_count());
 }
 
 TEST_F(ConnectionTesterTest, DeleteWhileInProgress) {
   ASSERT_TRUE(test_server_.Start());
 
   scoped_ptr<ConnectionTester> tester(
       new ConnectionTester(&test_delegate_,
                            proxy_script_fetcher_context_.get(),
-                           NULL));
+                           NULL,
+                           v8::Isolate::GetCurrent()));
 
   // Start the test suite on URL "echoall".
   // TODO(eroman): Is this URL right?
   tester->RunAllTests(test_server_.GetURL("echoall"));
 
   // Don't run the message loop at all.  Otherwise the experiment's request may
   // complete and post a task to run the next experiment before we quit the
   // message loop.
 
   EXPECT_EQ(1, test_delegate_.start_connection_test_suite_count());
@@ skipping 10 matching lines @@
   // any pending tasks instead of running them. This causes a problem with
   // net::ClientSocketPoolBaseHelper, since the "Group" holds a pointer
   // |backup_task| that it will try to deref during the destructor, but
   // depending on the order that pending tasks were deleted in, it might
   // already be invalid! See http://crbug.com/43291.
   MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
   MessageLoop::current()->Run();
 }
 
 }  // namespace