Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11959009: Don't use Error.toSafeString in List constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index 57bf1e0f507403cbe624b168eca7d7564dd21385..fb84ae6540cf612b40447822621175210e3879c7 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -487,16 +487,10 @@ class Primitives {
}
static List newGrowableList(length) {
- // TODO(sra): For good concrete type analysis we need the JS-type to
- // specifically name the JavaScript Array implementation. 'List' matches
- // all the dart:html types that implement List<T>.
return JS('=List', r'new Array(#)', length);
}
static List newFixedList(length) {
- // TODO(sra): For good concrete type analysis we need the JS-type to
- // specifically name the JavaScript Array implementation. 'List' matches
- // all the dart:html types that implement List<T>.
var result = JS('=List', r'new Array(#)', length);
JS('void', r'#.fixed$length = #', result, true);
return result;
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698