Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: Source/core/editing/Selection.idl

Issue 1195833002: Selection attributes changes from long to unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated missed return statement Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/Selection.idl
diff --git a/Source/core/editing/Selection.idl b/Source/core/editing/Selection.idl
index a7ad07b414cbc02147f84e07a9b0386b600e5cb4..4d84614bab030ae551520260d0d9a84f99a2c0cf 100644
--- a/Source/core/editing/Selection.idl
+++ b/Source/core/editing/Selection.idl
@@ -29,35 +29,34 @@
// http://w3c.github.io/selection-api/#idl-def-Selection
-// TODO(yoichio): All long types should be unsigned long. crbug.com/391673
[
ImplementedAs=DOMSelection,
WillBeGarbageCollected,
] interface Selection {
readonly attribute Node? anchorNode;
- readonly attribute long anchorOffset;
+ readonly attribute unsigned long anchorOffset;
readonly attribute Node? focusNode;
- readonly attribute long focusOffset;
+ readonly attribute unsigned long focusOffset;
readonly attribute boolean isCollapsed;
- readonly attribute long rangeCount;
- [RaisesException] Range getRangeAt(long index);
+ readonly attribute unsigned long rangeCount;
+ [RaisesException] Range getRangeAt(unsigned long index);
void addRange(Range range);
// TODO(yoichio): Implement removeRange. crbug.com/391673
//void removeRange(Range range);
void removeAllRanges();
- // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
+ // TODO(yoichio): The node argumendt should not be nullable. crbug.com/391673
// TODO(philipj): The offset argument should not have a default value.
- [RaisesException] void collapse(Node? node, optional long offset = 0);
+ [RaisesException] void collapse(Node? node, optional unsigned long offset = 0);
[RaisesException] void collapseToStart();
[RaisesException] void collapseToEnd();
// TODO(philipj): The offset argument should not have a default value.
- [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset = 0);
+ [RaisesException, TypeChecking=Interface] void extend(Node node, optional unsigned long offset = 0);
// TODO(philipj): The arguments should be anchorNode, anchorOffset,
// focusNode and focusOffset, and none of them should be optional.
[MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent([Default=Undefined] optional Node baseNode,
- [Default=Undefined] optional long baseOffset,
+ [Default=Undefined] optional unsigned long baseOffset,
[Default=Undefined] optional Node extentNode,
- [Default=Undefined] optional long extentOffset);
+ [Default=Undefined] optional unsigned long extentOffset);
[RaisesException, TypeChecking=Interface] void selectAllChildren(Node node);
[CustomElementCallbacks] void deleteFromDocument();
// TODO(philipj): The arguments should not be optional.
@@ -71,9 +70,9 @@
// https://github.com/w3c/selection-api/issues/34
[MeasureAs=SelectionBaseNode] readonly attribute Node? baseNode;
- [MeasureAs=SelectionBaseOffset] readonly attribute long baseOffset;
+ [MeasureAs=SelectionBaseOffset] readonly attribute unsigned long baseOffset;
[MeasureAs=SelectionExtentNode] readonly attribute Node? extentNode;
- [MeasureAs=SelectionExtentOffset] readonly attribute long extentOffset;
+ [MeasureAs=SelectionExtentOffset] readonly attribute unsigned long extentOffset;
// https://github.com/w3c/selection-api/issues/14
[MeasureAs=SelectionType] readonly attribute DOMString type;
@@ -87,5 +86,5 @@
[Default=Undefined] optional DOMString granularity);
// https://github.com/w3c/selection-api/issues/38
- [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional long offset = 0);
+ [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional unsigned long offset = 0);
};
« Source/core/editing/DOMSelection.cpp ('K') | « Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698