Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: Source/core/editing/DOMSelection.h

Issue 1195833002: Selection attributes changes from long to unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated missed return statement Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/DOMSelection.cpp » ('j') | Source/core/editing/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/DOMSelection.h
diff --git a/Source/core/editing/DOMSelection.h b/Source/core/editing/DOMSelection.h
index cb45a71fc39ef18307b669f5def12eb824ee1d9a..e00ea1b1e0e173ff45bb68e24e3311d4b90fd55f 100644
--- a/Source/core/editing/DOMSelection.h
+++ b/Source/core/editing/DOMSelection.h
@@ -61,11 +61,11 @@ public:
// Safari Selection Object API
// These methods return the valid equivalents of internal editing positions.
Node* baseNode() const;
- int baseOffset() const;
+ unsigned baseOffset() const;
Node* extentNode() const;
- int extentOffset() const;
+ unsigned extentOffset() const;
String type() const;
- void setBaseAndExtent(Node* baseNode, int baseOffset, Node* extentNode, int extentOffset, ExceptionState&);
+ void setBaseAndExtent(Node* baseNode, unsigned baseOffset, Node* extentNode, unsigned extentOffset, ExceptionState&);
void modify(const String& alter, const String& direction, const String& granularity);
// Mozilla Selection Object API
@@ -75,16 +75,16 @@ public:
// expansion.
// These methods return the valid equivalents of internal editing positions.
Node* anchorNode() const;
- int anchorOffset() const;
+ unsigned anchorOffset() const;
Node* focusNode() const;
- int focusOffset() const;
+ unsigned focusOffset() const;
bool isCollapsed() const;
- int rangeCount() const;
- void collapse(Node*, int offset, ExceptionState&);
+ unsigned rangeCount() const;
+ void collapse(Node*, unsigned offset, ExceptionState&);
void collapseToEnd(ExceptionState&);
void collapseToStart(ExceptionState&);
- void extend(Node*, int offset, ExceptionState&);
- PassRefPtrWillBeRawPtr<Range> getRangeAt(int, ExceptionState&);
+ void extend(Node*, unsigned offset, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Range> getRangeAt(unsigned, ExceptionState&);
void removeAllRanges();
void addRange(Range*);
void deleteFromDocument();
@@ -105,7 +105,7 @@ private:
const VisibleSelection& visibleSelection() const;
Node* shadowAdjustedNode(const Position&) const;
- int shadowAdjustedOffset(const Position&) const;
+ unsigned shadowAdjustedOffset(const Position&) const;
bool isValidForPosition(Node*) const;
« no previous file with comments | « no previous file | Source/core/editing/DOMSelection.cpp » ('j') | Source/core/editing/DOMSelection.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698