LayoutTests/editing/selection/skip-over-contenteditable.html - Issue 1195833002: Selection attributes changes from long to unsigned long

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/skip-over-contenteditable.html

Issue 1195833002: Selection attributes changes from long to unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixes offset error message Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/selection-invalid-offset-expected.txt ('k') | LayoutTests/editing/selection/skip-over-uneditable-in-contenteditable.html » ('j') | Source/core/editing/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/selection/skip-over-contenteditable.html

diff --git a/LayoutTests/editing/selection/skip-over-contenteditable.html b/LayoutTests/editing/selection/skip-over-contenteditable.html

index 14c284e844e2cbc7b97bb3bc7c4750e4b9090004..daf75ef2c4999ab3af1b601905dbd03072196d79 100644

--- a/LayoutTests/editing/selection/skip-over-contenteditable.html

+++ b/LayoutTests/editing/selection/skip-over-contenteditable.html

@@ -15,27 +15,27 @@ var before = document.getElementById("before");

var after = document.getElementById("after");

var sel = window.getSelection();

-sel.setBaseAndExtent(before, 0, before, 6);

+sel.setBaseAndExtent(before, 0, before, 1);

sel.modify("extend", "forward", "character");

shouldBe("sel.focusNode", "after");

-sel.setBaseAndExtent(after, 5, after, 0);

+sel.setBaseAndExtent(after, 1, after, 0);

sel.modify("extend", "backward", "character");

shouldBe("sel.focusNode.parentElement", "before");

-sel.setBaseAndExtent(before, 0, before, 6);

+sel.setBaseAndExtent(before, 0, before, 1);

sel.modify("extend", "forward", "word");

shouldBe("sel.focusNode.parentElement", "after");

-sel.setBaseAndExtent(after, 5, after, 0);

+sel.setBaseAndExtent(after, 1, after, 0);

sel.modify("extend", "backward", "word");

shouldBe("sel.focusNode.parentElement", "before");

-sel.setBaseAndExtent(before, 0, before, 6);

+sel.setBaseAndExtent(before, 0, before, 1);

sel.modify("extend", "forward", "line");

shouldBe("sel.focusNode.parentElement", "after");

-sel.setBaseAndExtent(after, 5, after, 0);

+sel.setBaseAndExtent(after, 1, after, 0);

sel.modify("extend", "backward", "line");

shouldBe("sel.focusNode.parentElement", "before");

</script>