LayoutTests/editing/selection/selection-invalid-offset.html - Issue 1195833002: Selection attributes changes from long to unsigned long

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/selection-invalid-offset.html

Issue 1195833002: Selection attributes changes from long to unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixes offset error message Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/extend-expected.txt ('k') | LayoutTests/editing/selection/selection-invalid-offset-expected.txt » ('j') | Source/core/editing/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/selection/selection-invalid-offset.html

diff --git a/LayoutTests/editing/selection/selection-invalid-offset.html b/LayoutTests/editing/selection/selection-invalid-offset.html

index d0f8bc64f92eaf9a7355937aea5ada00ac2559ed..fa6493f295095baba9ebbed628fc35999d947506 100644

--- a/LayoutTests/editing/selection/selection-invalid-offset.html

+++ b/LayoutTests/editing/selection/selection-invalid-offset.html

@@ -1,5 +1,5 @@

<body>

-You should see 7 OKs below (and not hang): <br>

+You should see 9 OKs below (and not hang): <br>

if (window.testRunner)

testRunner.dumpAsText();

@@ -22,8 +22,6 @@ shouldThrowIndexSizeErrorException("selection.collapse(body, -1);");

shouldThrowIndexSizeErrorException("selection.getRangeAt(-1);");

shouldThrowIndexSizeErrorException("selection.getRangeAt(10000);");

shouldThrowIndexSizeErrorException("selection.collapse(body, 10000);");

-// these should throw as well but don't at the moment. Just checking they don't crash.

-selection.setBaseAndExtent(body, 1000, body, 0);

-selection.setBaseAndExtent(body, 0, body, 10000);

+shouldThrowIndexSizeErrorException("selection.setBaseAndExtent(body, 1000, body, 0)");

+shouldThrowIndexSizeErrorException("selection.setBaseAndExtent(body, 0, body, 10000)");

</script>