LayoutTests/editing/selection/extend-expected.txt - Issue 1195833002: Selection attributes changes from long to unsigned long

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/extend-expected.txt

Issue 1195833002: Selection attributes changes from long to unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixes offset error message Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 foobarbaz	1 foobarbaz

2 Success: window.getSelection() is ar.	2 Success: window.getSelection() is ar.

3 Success: s.extend(span2.firstChild, 4) raised IndexSizeError: Failed to execute 'extend' on 'Selection': 4 is larger than the given node's length..	3 Success: s.extend(span2.firstChild, 4) raised IndexSizeError: Failed to execute 'extend' on 'Selection': 4 is larger than the given node's length..

4 Success: s.extend(span2.firstChild, -1) raised IndexSizeError: Failed to execute 'extend' on 'Selection': -1 is not a valid offset..	4 Success: s.extend(span2.firstChild, -1) raised IndexSizeError: Failed to execute 'extend' on 'Selection': 4294967295 is larger than the given node's length..

5 Success: window.getSelection() is b.	5 Success: window.getSelection() is b.

6 Success: window.getSelection() is arbaz.	6 Success: window.getSelection() is arbaz.

7 Success: s.extend() raised TypeError: Failed to execute 'extend' on 'Selection': 1 argument required, but only 0 present..	7 Success: s.extend() raised TypeError: Failed to execute 'extend' on 'Selection': 1 argument required, but only 0 present..

8 Success: s.extend(null, 0) raised TypeError: Failed to execute 'extend' on 'Sele ction': parameter 1 is not of type 'Node'..	8 Success: s.extend(null, 0) raised TypeError: Failed to execute 'extend' on 'Sele ction': parameter 1 is not of type 'Node'..

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/selection-invalid-offset.html » ('j') | Source/core/editing/DOMSelection.cpp » ('J')