Path fix for data-driving formatting tests.

pkg/analyzer/test/services/formatter_test.dart

Index: pkg/analyzer/test/services/formatter_test.dart
===================================================================
--- pkg/analyzer/test/services/formatter_test.dart	(revision 31301)
+++ pkg/analyzer/test/services/formatter_test.dart	(working copy)
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-//import 'dart:io';
+import 'dart:io';
 
 import 'package:unittest/unittest.dart';
 
@@ -11,23 +11,24 @@
 import 'package:analyzer/src/services/formatter_impl.dart';
 import 'package:analyzer/src/services/writer.dart';
 
+// Test data location
+const TEST_DATA_DIR = 'pkg/analyzer/test/services/data';

[kustermann, 2014/01/02 10:22:00]

You should not use forward slashes, windows uses backwards slashes and the "new
File()" constructor takes a native path AFAIK.

[pquitslund, 2014/01/02 18:39:11]

Ah, yes.  I mistakenly thought that the new File constructor was more magical. 
As per your advice below, I'm taking a different approach now, based on
Platform.script so this is moot.

+
 main() {
 
-//TODO(pquitslund): disabled pending build investigation
+  /// Data driven statement tests
+  group('stmt_tests.data', () {
+    runTests('stmt_tests.data', (input, expectedOutput) {
+      expect(formatStatement(input) + '\n', equals(expectedOutput));
+    });
+  });
 
-//  /// Data driven statement tests
-//  group('stmt_tests.data', () {
-//    runTests(new File('data/stmt_tests.data'), (input, expectedOutput) {
-//      expect(formatStatement(input) + '\n', equals(expectedOutput));
-//    });
-//  });
-//
-//  /// Data driven compilation unit tests
-//  group('cu_tests.data', () {
-//    runTests(new File('data/cu_tests.data'), (input, expectedOutput) {
-//      expectCUFormatsTo(input, expectedOutput);
-//    });
-//  });
+  /// Data driven compilation unit tests
+  group('cu_tests.data', () {
+    runTests('cu_tests.data', (input, expectedOutput) {
+      expectCUFormatsTo(input, expectedOutput);
+    });
+  });
 
   /// Formatter tests
   group('formatter', () {
@@ -1308,9 +1309,11 @@
     expect(formatStatement(src, options:
       new FormatterOptions(codeTransforms: transforms)), equals(expected));
 
-runTests(testFile, expectClause(input, output)) {
 
+runTests(testFileName, expectClause(input, output)) {
+
   var testIndex = 1;
+  var testFile = new File('$TEST_DATA_DIR/$testFileName');

[kustermann, 2014/01/02 10:22:00]

Since you import 'dart:io' anyway, you could use dart:io's Platform.script (i.e.
take the Platform.script Uri drop the last path components until you see
"pkg/analyzer" at the end and then navigate to the data directory).

[pquitslund, 2014/01/02 18:39:11]

Perfect. Great idea!

   var lines = testFile.readAsLinesSync();
 
   for (var i = 1; i < lines.length; ++i) {