Refactoring: Remove a boolean parameter from EditingStyle::wrappingStyleForSerialization

Refactoring: Remove a boolean parameter from EditingStyle::wrappingStyleForSerialization

This CL removes a boolean parameter from EditingStyle::
wrappingStyleForSerialization, separates this into two functions and
updates the callers.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197708

[hajimehoshi, 2015-06-23 11:17:36]

hajimehoshi@chromium.org changed reviewers:
+ yosin@chromium.org

[hajimehoshi, 2015-06-23 11:17:36]

PTAL

[yosin_UTC9, 2015-06-23 13:30:07]

https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
File Source/core/editing/EditingStyle.h (right):

https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
Source/core/editing/EditingStyle.h:129: static
PassRefPtrWillBeRawPtr<EditingStyle>
wrappingStyleForSerializationAnnotateForInterchange(ContainerNode* context);
This name is confusing.
How about 
- wrappingStyleForAnnotatedSerialization(),
- wrappingStyleForSerializationWithAnnotation()
- wrappingStyleForSerializationWithAnnotationForInterchange()

[hajimehoshi, 2015-06-24 05:09:21]

On 2015/06/23 13:30:07, Yosi_UTC9 wrote:
>
https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
> File Source/core/editing/EditingStyle.h (right):
> 
>
https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
> Source/core/editing/EditingStyle.h:129: static
> PassRefPtrWillBeRawPtr<EditingStyle>
> wrappingStyleForSerializationAnnotateForInterchange(ContainerNode* context);
> This name is confusing.
> How about 
> - wrappingStyleForAnnotatedSerialization(),
> - wrappingStyleForSerializationWithAnnotation()
> - wrappingStyleForSerializationWithAnnotationForInterchange()

I think wrappingStyleForAnnotatedSerialization is better (because this is the
shortest :-)

[hajimehoshi, 2015-06-24 05:16:42]

https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
File Source/core/editing/EditingStyle.h (right):

https://codereview.chromium.org/1195813003/diff/20001/Source/core/editing/Edi...
Source/core/editing/EditingStyle.h:129: static
PassRefPtrWillBeRawPtr<EditingStyle>
wrappingStyleForSerializationAnnotateForInterchange(ContainerNode* context);
On 2015/06/23 13:30:07, Yosi_UTC9 wrote:
> This name is confusing.
> How about 
> - wrappingStyleForAnnotatedSerialization(),
> - wrappingStyleForSerializationWithAnnotation()
> - wrappingStyleForSerializationWithAnnotationForInterchange()

Done.

[yosin_UTC9, 2015-06-24 05:52:17]

lgtm w/ asking for cleanup

https://codereview.chromium.org/1195813003/diff/40001/Source/core/editing/Edi...
File Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1195813003/diff/40001/Source/core/editing/Edi...
Source/core/editing/EditingStyle.cpp:1098: // Styles that Mail blockquotes
contribute should only be placed on the Mail blockquote,
Could you fill comment lines in 80 chars?

[hajimehoshi, 2015-06-24 06:03:16]

Thank you!

https://codereview.chromium.org/1195813003/diff/40001/Source/core/editing/Edi...
File Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1195813003/diff/40001/Source/core/editing/Edi...
Source/core/editing/EditingStyle.cpp:1098: // Styles that Mail blockquotes
contribute should only be placed on the Mail blockquote,
On 2015/06/24 05:52:17, Yosi_UTC9 wrote:
> Could you fill comment lines in 80 chars?

Done.

[hajimehoshi, 2015-06-24 06:03:21]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-06-24 06:03:21]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1195813003/#ps60001
(title: "comment 80 chars in a line")

[commit-bot: I haz the power, 2015-06-24 06:03:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1195813003/60001

[commit-bot: I haz the power, 2015-06-24 06:55:03]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197708