Implement Pepper proxy for PPB_DirectoryReader

ppapi/proxy/directory_reader_resource.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_PROXY_DIRECTORY_READER_RESOURCE_H_
+#define PPAPI_PROXY_DIRECTORY_READER_RESOURCE_H_
+
+#include <queue>
+#include <vector>
+
+#include "base/basictypes.h"
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
+#include "ppapi/shared_impl/ppb_file_ref_shared.h"
+#include "ppapi/shared_impl/resource.h"
+#include "ppapi/thunk/ppb_directory_reader_api.h"
+
+namespace ppapi {
+
+class TrackedCallback;
+
+namespace proxy {
+
+class PPAPI_PROXY_EXPORT DirectoryReaderResource
+    : public PluginResource,
+      public NON_EXPORTED_BASE(thunk::PPB_DirectoryReader_API) {
+ public:
+  DirectoryReaderResource(Connection connection,
+                          PP_Instance instance,
+                          PP_Resource directory_ref);
+  virtual ~DirectoryReaderResource();
+
+  // Resource overrides.
+  virtual thunk::PPB_DirectoryReader_API* AsPPB_DirectoryReader_API() OVERRIDE;
+
+  // PPB_DirectoryReader_API.
+  virtual int32_t GetNextEntry(
+      PP_DirectoryEntry_Dev* entry,
+      scoped_refptr<TrackedCallback> callback) OVERRIDE;
+
+ private:
+  void OnPluginMsgGetEntriesReply(
+      const ResourceMessageReplyParams& params,
+      const std::vector<ppapi::PPB_FileRef_CreateInfo>& infos,
+      const std::vector<PP_FileType>& file_types,
+      bool has_more);
+  bool FillUpEntry();
+
+  // Owning a reference to the directory to be read.
+  PP_Resource directory_ref_;

[dmichael (off chromium), 2013/01/29 21:22:42]

Probably should be a scoped_refptr instead?

[dmichael (off chromium), 2013/01/29 21:25:31]

Let me clarify a bit...  you should just hold a
scoped_refptr<PPB_FileRef_Shared>, or whatever the internal type is. You
shouldn't rely on the reference count in the ResourceTracker being sane, since
the plugin can muck with it.

[nhiroki, 2013/01/30 09:24:51]

I see, thanks for your clear explanation! Done.

+
+  // Owning references to files and directories.
+  std::queue<PP_DirectoryEntry_Dev> entries_;

[dmichael (off chromium), 2013/01/29 21:22:42]

ditto, scoped_refptr

[nhiroki, 2013/01/30 09:24:51]

Done.

+
+  PP_DirectoryEntry_Dev* output_;
+  bool has_more_;
+
+  scoped_refptr<TrackedCallback> callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(DirectoryReaderResource);
+};
+
+}  // namespace proxy
+}  // namespace ppapi
+
+#endif  // PPAPI_PROXY_DIRECTORY_READER_RESOURCE_H_