Source/platform/scroll/ScrollableArea.cpp - Issue 1195803003: Report accurate Overscroll on handleWheel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableArea.cpp

Issue 1195803003: Report accurate Overscroll on handleWheel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollableArea.cpp

diff --git a/Source/platform/scroll/ScrollableArea.cpp b/Source/platform/scroll/ScrollableArea.cpp

index 60e1c05d25625e201fe7c6695625924b33d69585..2f6db26940b494fe87e6952d258f20e227a054cd 100644

--- a/Source/platform/scroll/ScrollableArea.cpp

+++ b/Source/platform/scroll/ScrollableArea.cpp

@@ -301,7 +301,7 @@ ScrollResult ScrollableArea::handleWheel(const PlatformWheelEvent& wheelEvent)

{

// Wheel events which do not scroll are used to trigger zooming.

if (!wheelEvent.canScroll())

- return ScrollResult();

+ return ScrollResult(false, false, wheelEvent.deltaX(), wheelEvent.deltaY());

bokan 2015/06/23 16:20:45 Doesn't this mean that a browser zoom (ctrl + whee

MuVen 2015/06/25 12:55:51 Done. True, i checked it, it wont trigger overscro

cancelProgrammaticScrollAnimation();

return scrollAnimator()->handleWheelEvent(wheelEvent);