Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: Source/core/frame/RootFrameViewport.cpp

Issue 1195803003: Report accurate Overscroll on handleWheel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/input/EventHandler.h » ('j') | Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/RootFrameViewport.cpp
diff --git a/Source/core/frame/RootFrameViewport.cpp b/Source/core/frame/RootFrameViewport.cpp
index 3ba978fd47f6bf304fb7f05ff327a2e0d915b761..e3a33ff359e6dab14f1de2fae4f6973cbf83a4f7 100644
--- a/Source/core/frame/RootFrameViewport.cpp
+++ b/Source/core/frame/RootFrameViewport.cpp
@@ -122,7 +122,7 @@ ScrollResult RootFrameViewport::handleWheel(const PlatformWheelEvent& event)
DoublePoint usedLocationDelta(visualViewport().scrollPositionDouble() - oldOffset);
if (!viewScrollResult.didScroll() && usedLocationDelta == DoublePoint::zero())
- return ScrollResult();
+ return ScrollResult(false, false, viewScrollResult.unusedScrollDeltaX, viewScrollResult.unusedScrollDeltaY);
bokan 2015/06/23 16:20:45 This is returning the layout viewport's overscroll
MuVen 2015/06/25 12:55:51 Done.
DoubleSize unusedLocationDelta(locationDelta - usedLocationDelta);
bool didScrollX = viewScrollResult.didScrollX || unusedLocationDelta.width();
« no previous file with comments | « no previous file | Source/core/input/EventHandler.h » ('j') | Source/core/input/EventHandler.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698