Source/core/frame/RootFrameViewport.cpp - Issue 1195803003: Report accurate Overscroll on handleWheel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RootFrameViewport.cpp

Issue 1195803003: Report accurate Overscroll on handleWheel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments and added testcase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/RootFrameViewport.cpp

diff --git a/Source/core/frame/RootFrameViewport.cpp b/Source/core/frame/RootFrameViewport.cpp

index 3ba978fd47f6bf304fb7f05ff327a2e0d915b761..2e7a9fd40fe27d7d8fdccf73ae6861f90e833e88 100644

--- a/Source/core/frame/RootFrameViewport.cpp

+++ b/Source/core/frame/RootFrameViewport.cpp

@@ -122,7 +122,7 @@ ScrollResult RootFrameViewport::handleWheel(const PlatformWheelEvent& event)

DoublePoint usedLocationDelta(visualViewport().scrollPositionDouble() - oldOffset);

if (!viewScrollResult.didScroll() && usedLocationDelta == DoublePoint::zero())

- return ScrollResult();

+ return ScrollResult(false, false, viewScrollResult.unusedScrollDeltaX - usedLocationDelta.x(), viewScrollResult.unusedScrollDeltaY - usedLocationDelta.y());

DoubleSize unusedLocationDelta(locationDelta - usedLocationDelta);

bool didScrollX = viewScrollResult.didScrollX || unusedLocationDelta.width();

« no previous file with comments | « no previous file | Source/core/frame/Settings.in » ('j') | Source/platform/scroll/ScrollAnimator.cpp » ('J')