Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 11958029: [Sync] Add support for proxy types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and rename local -> virtual Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index aed4432d3528992f8d0c3811e4771d9e83e76c0e..3f7f07794828f9c85e44629ee359edff56c1a449 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -2804,13 +2804,7 @@ class SyncManagerTestWithMockScheduler : public SyncManagerTest {
// Test that the configuration params are properly created and sent to
// ScheduleConfigure. No callback should be invoked. Any disabled datatypes
// should be purged.
-// Fails on Windows: crbug.com/139726
-#if defined(OS_WIN)
-#define MAYBE_BasicConfiguration DISABLED_BasicConfiguration
-#else
-#define MAYBE_BasicConfiguration BasicConfiguration
-#endif
-TEST_F(SyncManagerTestWithMockScheduler, MAYBE_BasicConfiguration) {
+TEST_F(SyncManagerTestWithMockScheduler, BasicConfiguration) {
ConfigureReason reason = CONFIGURE_REASON_RECONFIGURATION;
ModelTypeSet types_to_download(BOOKMARKS, PREFERENCES);
ModelSafeRoutingInfo new_routing_info;
@@ -2824,7 +2818,9 @@ TEST_F(SyncManagerTestWithMockScheduler, MAYBE_BasicConfiguration) {
WillOnce(DoAll(SaveArg<0>(&params), Return(true)));
// Set data for all types.
- for (ModelTypeSet::Iterator iter = ModelTypeSet::All().First(); iter.Good();
+ ModelTypeSet real_types = ModelTypeSet::All();
+ real_types.RemoveAll(VirtualTypes());
+ for (ModelTypeSet::Iterator iter = real_types.First(); iter.Good();
iter.Inc()) {
SetProgressMarkerForType(iter.Get(), true);
}
@@ -3010,13 +3006,7 @@ TEST_F(SyncManagerTest, PurgePartiallySyncedTypes) {
// Test CleanupDisabledTypes properly purges all disabled types as specified
// by the previous and current enabled params.
-// Fails on Windows: crbug.com/139726
-#if defined(OS_WIN)
-#define MAYBE_PurgeDisabledTypes DISABLED_PurgeDisabledTypes
-#else
-#define MAYBE_PurgeDisabledTypes PurgeDisabledTypes
-#endif
-TEST_F(SyncManagerTest, MAYBE_PurgeDisabledTypes) {
+TEST_F(SyncManagerTest, PurgeDisabledTypes) {
ModelSafeRoutingInfo routing_info;
GetModelSafeRoutingInfo(&routing_info);
ModelTypeSet enabled_types = GetRoutingInfoTypes(routing_info);
@@ -3026,7 +3016,9 @@ TEST_F(SyncManagerTest, MAYBE_PurgeDisabledTypes) {
EXPECT_TRUE(enabled_types.Equals(sync_manager_.InitialSyncEndedTypes()));
// Set progress markers for all types.
- for (ModelTypeSet::Iterator iter = ModelTypeSet::All().First(); iter.Good();
+ ModelTypeSet real_types = ModelTypeSet::All();
+ real_types.RemoveAll(VirtualTypes());
+ for (ModelTypeSet::Iterator iter = real_types.First(); iter.Good();
iter.Inc()) {
SetProgressMarkerForType(iter.Get(), true);
}

Powered by Google App Engine
This is Rietveld 408576698