sdk/lib/_internal/compiler/implementation/native_handler.dart - Issue 11958026: Stubbing out the initial library for Chrome application support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 11958026: Stubbing out the initial library for Chrome application support. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/libraries.dart » ('j') | sdk/lib/chrome/dart2js/chrome_dart2js.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/native_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/native_handler.dart b/sdk/lib/_internal/compiler/implementation/native_handler.dart

index c0af4bf09d038b30e783aab7607d3964f8f58072..aabb1e4bd9271a2e728a900e3a2da94e7e7108e7 100644

--- a/sdk/lib/_internal/compiler/implementation/native_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/native_handler.dart

@@ -455,6 +455,7 @@ void maybeEnableNative(Compiler compiler,

if (library.entryCompilationUnit.script.name.contains(

'dart/tests/compiler/dart2js_native')

|| libraryName == 'dart:async'

+ || libraryName == 'dart:chrome'

ahe 2013/01/17 18:41:27 Why do you need this?

blois 2013/01/17 21:03:30 I was under the impression that this is required f

ahe 2013/01/17 22:06:55 I think this is different from dart:html, etc. As

|| libraryName == 'dart:html'

|| libraryName == 'dart:html_common'

|| libraryName == 'dart:indexed_db'

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/libraries.dart » ('j') | sdk/lib/chrome/dart2js/chrome_dart2js.dart » ('J')