tools/dom/src/chrome/sample.dart - Issue 11958026: Stubbing out the initial library for Chrome application support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/dom/src/chrome/sample.dart

Issue 11958026: Stubbing out the initial library for Chrome application support. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 patch class _HttpSessionManager {	5

6 /* patch */ static Uint8List _getRandomBytes(int count)	6 part of chrome;

7 native "Crypto_GetRandomBytes";	7

	8 class ChromeApp {
	vsm 2013/01/17 15:31:28 Internal constructor for this class ala ChromeWind Internal constructor for this class ala ChromeWindow below? blois 2013/01/17 18:03:20 Done. Show quoted text On 2013/01/17 15:31:28, vsm wrote: > Internal constructor for this class ala ChromeWindow below? Done.
	9 ChromeWindow get window => new ChromeWindow._();

8 }	10 }

	11

	12 class ChromeWindow {
	vsm 2013/01/17 15:31:28 Since chrome.app.window is a module and not an act Since chrome.app.window is a module and not an actual window, I'd be tempted to name this class differently. E.g., WindowModule? blois 2013/01/17 18:03:20 Done. In general I'm not quite sure of the nicest Show quoted text On 2013/01/17 15:31:28, vsm wrote: > Since chrome.app.window is a module and not an actual window, I'd be tempted to > name this class differently. E.g., WindowModule? Done. In general I'm not quite sure of the nicest way to expose these APIs- this follows the JS syntax, but it's not exactly 'darty'. But all this will get replaced.
	13 ChromeWindow._();

	14

	15 void create(String url) {

	16 JS('void', 'chrome.app.window.create(#)');

	17 }

	18 }

	19

	20 final app = new ChromeApp();

OLD	NEW