Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 11958015: Remove GlobalHandles::number_of_weak_handles_ and number_of_global_object_weak_handles_ (Closed)

Created:
7 years, 11 months ago by haraken
Modified:
7 years, 11 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Remove GlobalHandles::number_of_weak_handles_ and number_of_global_object_weak_handles_ This is a preparation patch for inlining MakeWeak() and Clear(). Given that NumberOfWeakHandles() is used only by CHECK_EQ() in serialized.cc and that NumberOfGlobalObjectWeakHandles is unused, it is wasteful to keep track of number_of_weak_handles_ and number_of_global_object_weak_handles_ at every MakeWeak() and Clear(). Instead, we can count the number at the point where NumberOfWeakHandles() or NumberOfGlobalObjectWeakHandles() is called. BUG= Committed: http://code.google.com/p/v8/source/detail?r=13443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -32 lines) Patch
M src/global-handles.h View 2 chunks +2 lines, -12 lines 0 comments Download
M src/global-handles.cc View 5 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
michael: NumberOfGlobalObjectWeakHandles() is unused. If you want to remove it, I'd be happy to remove ...
7 years, 11 months ago (2013-01-16 18:16:42 UTC) #1
Michael Starzinger
7 years, 11 months ago (2013-01-21 11:41:53 UTC) #2
LGTM. I'll land this. Let's keep NumberOfGlobalObjectWeakHandles() for now, I
can imagine it being valuable during debugging.

Powered by Google App Engine
This is Rietveld 408576698