content/browser/devtools/devtools_http_handler_impl.cc - Issue 11958010: DevTools: brush up remote debugging browser target: use callbacks, make handlers implementation a m…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 11958010: DevTools: brush up remote debugging browser target: use callbacks, make handlers implementation a m… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed (left error handling order in place) Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_http_handler_impl.cc

diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc

index c2670af18c4d85b7c89ed8f5a410fef70fafa0da..428370d16ea01cf1ed74f34e115371ac183af754 100644

--- a/content/browser/devtools/devtools_http_handler_impl.cc

+++ b/content/browser/devtools/devtools_http_handler_impl.cc

@@ -614,7 +614,7 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(

}

browser_target_.reset(new DevToolsBrowserTarget(

thread_->message_loop_proxy().get(), server_.get(), connection_id));

- browser_target_->RegisterHandler(new DevToolsTracingHandler());

+ browser_target_->RegisterDomainHandler(new DevToolsTracingHandler());

AcceptWebSocket(connection_id, request);

return;

}

« no previous file with comments | « content/browser/devtools/devtools_browser_target.cc ('k') | content/browser/devtools/devtools_tracing_handler.h » ('j') | no next file with comments »