Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 11958009: Do not track parameter types of closures, since closure calls can be generated during the emitter. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (revision 17130)
+++ sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (working copy)
@@ -485,6 +485,13 @@
void registerDynamicInvocation(HInvokeDynamic node,
Selector selector,
HTypeMap types) {
+ if (selector.isClosureCall()) {
+ // We cannot use the current framework to do optimizations based
+ // on the 'call' selector because we are also generating closure
+ // calls during the emitter phase, which at this point, does not
+ // track parameter types, nor invalidates optimized methods.
+ return;
+ }
HTypeList providedTypes =
new HTypeList.fromDynamicInvocation(node, selector, types);
if (!selectorTypeMap.containsKey(selector)) {
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698