Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: cc/layer_tree_host_impl.cc

Issue 11958004: Make new-style page scale work on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Delete maxScrollOffsetChangedByDeviceScaleFactor test Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_tree_host_impl.cc
diff --git a/cc/layer_tree_host_impl.cc b/cc/layer_tree_host_impl.cc
index e6b9ac99e0d49ae673f001b56a4ce6ad514d74aa..0567c1a93e912abba323607530f155d1f57ec46c 100644
--- a/cc/layer_tree_host_impl.cc
+++ b/cc/layer_tree_host_impl.cc
@@ -254,7 +254,7 @@ void LayerTreeHostImpl::startPageScaleAnimation(gfx::Vector2d targetOffset, bool
return;
gfx::Vector2dF scrollTotal = rootScrollLayer()->scrollOffset() + rootScrollLayer()->scrollDelta();
- gfx::SizeF scaledContentSize = contentSize();
+ gfx::SizeF scaledContentSize = activeTree()->ScrollableSize();
danakj 2013/01/17 18:02:49 rename scaledContentSize to what it now holds as w
aelias_OOO_until_Jul13 2013/01/17 19:59:46 Done.
aelias_OOO_until_Jul13 2013/01/17 19:59:46 Done.
if (!m_settings.pageScalePinchZoomEnabled) {
scrollTotal.Scale(1 / m_pinchZoomViewport.page_scale_factor());
scaledContentSize.Scale(1 / m_pinchZoomViewport.page_scale_factor());
@@ -554,11 +554,6 @@ void LayerTreeHostImpl::setBackgroundTickingEnabled(bool enabled)
m_timeSourceClientAdapter->setActive(enabled);
}
-gfx::Size LayerTreeHostImpl::contentSize() const
-{
- return activeTree()->ContentSize();
-}
-
static inline RenderPass* findRenderPassById(RenderPass::Id renderPassId, const LayerTreeHostImpl::FrameData& frame)
{
RenderPassIdHashMap::const_iterator it = frame.renderPassesById.find(renderPassId);
@@ -768,8 +763,8 @@ CompositorFrameMetadata LayerTreeHostImpl::makeCompositorFrameMetadata() const
if (!m_settings.pageScalePinchZoomEnabled)
metadata.root_scroll_offset.Scale(1 / m_pinchZoomViewport.page_scale_factor());
metadata.page_scale_factor = m_pinchZoomViewport.total_page_scale_factor();
- metadata.viewport_size = m_pinchZoomViewport.Bounds().size();
- metadata.root_layer_size = contentSize();
+ metadata.viewport_size = m_pinchZoomViewport.ZoomedViewport().size();
+ metadata.root_layer_size = activeTree()->ScrollableSize();
metadata.min_page_scale_factor = m_pinchZoomViewport.min_page_scale_factor();
metadata.max_page_scale_factor = m_pinchZoomViewport.max_page_scale_factor();
@@ -1028,6 +1023,7 @@ void LayerTreeHostImpl::setViewportSize(const gfx::Size& layoutViewportSize, con
m_deviceViewportSize = deviceViewportSize;
m_pinchZoomViewport.set_layout_viewport_size(layoutViewportSize);
+ m_pinchZoomViewport.set_device_viewport_size(deviceViewportSize);
updateMaxScrollOffset();
@@ -1371,7 +1367,7 @@ void LayerTreeHostImpl::computePinchZoomDeltas(ScrollAndScaleSet* scrollInfo)
scrollBegin.Scale(m_pinchZoomViewport.page_scale_delta());
float scaleBegin = m_pinchZoomViewport.total_page_scale_factor();
float pageScaleDeltaToSend = m_pinchZoomViewport.min_page_scale_factor() / m_pinchZoomViewport.page_scale_factor();
- gfx::SizeF scaledContentsSize = gfx::ScaleSize(contentSize(), pageScaleDeltaToSend);
+ gfx::SizeF scaledContentsSize = gfx::ScaleSize(activeTree()->ScrollableSize(), pageScaleDeltaToSend);
danakj 2013/01/17 18:02:49 rename scaledContentsSize here also
aelias_OOO_until_Jul13 2013/01/17 19:59:46 Done.
gfx::Vector2d anchorOffset = m_previousPinchAnchor.OffsetFromOrigin();
gfx::Vector2dF scrollEnd = scrollBegin + anchorOffset;

Powered by Google App Engine
This is Rietveld 408576698