Issue 11958003: Roll Skia DEPS to r7212

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11958003: Roll Skia DEPS to r7212 (Closed)

Created:
7 years, 11 months ago by robertphillips

Modified:
7 years, 11 months ago

Reviewers:
reed1

CC:
chromium-reviews, skia-dev_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to r7212 control: https://codereview.chromium.org/11966002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177148

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	skia/skia.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertphillips

I believe this is 'good' despite the win_layout* bots going away again and the 'win' ...

7 years, 11 months ago (2013-01-16 13:28:37 UTC) #1

I believe this is 'good' despite the win_layout* bots going away again and the
'win' bot flaking out. Here are the discrepancies between the roll and control:

win
   roll:    
            browser_tests failed 66
                WhitelistedExtension
                AppProcess
                AppProcessInstances
                SessionCookies
                TabClosingWhenRemovingExtension
                Database
                Status511
                TwoBrokenTabs
                ExecuteScriptPermissions
                Tabs
                ActiveTab
                AlertBasic
                ApiTest
                AutotestPrivate
                BackgroundScripts
                BookmarkManager
                BookmarkManagerEditDisabled
                Bookmarks
                Canvas2D
                CaptureVisibleDisabled
                CaptureVisibleFile
                CaptureVisibleNoFile
                ContentScriptAboutBlankIframes
                ContentScriptAllFrames
                ContentScriptExtensionIframe
                ContentScriptExtensionProcess
                ContentScriptFragmentNavigation
                ContentScriptOtherExtensions
                ContentScriptPermissionsApi
                ContentSettings
                GetAlertsForTab
                TabCrashBrowser
                TabEvents
                TabHighlight
                TabOnRemoved
                TabOpener
                TabsOnUpdated
                UpdateWindowResize
                Uninstall
                WebRequestComplex
                WebRequestDeclarative
                WebRequestDeclarativePermissions
                WebRequestNewTab
                WebRequestSimple
                DataDrivenHeuristics00
                IsolatedAppProcessModel
                ExitStatus
                ProgressEvents
                netInternalsTimelineViewLoadLog
                LoadNTPInExistingProcess
                Graphics2D_Scroll
                Graphics3D
                Messaging
                ExtensionInstallBlacklist
                TranslateEnabled
                PrerenderSSLClientCertTopLevel
                ProcessOverflow
                PRE_SessionStorage
                SessionStorage
                SafeBrowsingServerTest
                RestoresCrossSiteForwardAndBackwardNavs
                HideOnSecondClick
                CrashOnceOnly
                CrossProcess
                ForwardBack
                History
            content_browsertests failed 1
                LimitTotal
   control: 
            browser_tests failed 15
                WhitelistedExtension
                TabClosingWhenRemovingExtension
                LoginExtraNavigations
                Uninstall
                WebRequestDeclarative
                CrossProcessClientRedirect
                SupplyRedundantAuths
                SimpleURLNotInAnyListNavigateAround
                ExitStatus
                LoadNTPInExistingProcess
                Messaging
                TranslateEnabled
                URLBlacklist
                ProcessOverflow
                HideOnSecondClick

win_gpu
   roll:    
            content_browsertests failed 2
                SingleWindowDoesNotExceedLimit
                MANUAL_conformance_attribs_gl_enable_vertex_attrib ***********
   control: 
            content_browsertests failed 2
                MANUAL_Kill
                SingleWindowDoesNotExceedLimit

mac_layout_rel
   roll:    compile failed - dup symbol AudioDestinationChromiumD0Ev
   control: compile failed - dup symbol AudioDestinationChromiumD0Ev

lgtm

Expand Messages | Collapse Messages