Issue 11958002: overscroll: Make sure screenshot for a NavigationEntry gets reset properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11958002: overscroll: Make sure screenshot for a NavigationEntry gets reset properly. (Closed)

Created:
7 years, 11 months ago by sadrul

Modified:
7 years, 11 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

overscroll: Make sure screenshot for a NavigationEntry gets reset properly. If taking screenshot (or encoding it in a proper format) of a NavigationEntry fails for some reason, make sure it gets reset properly so that it doesn't carry a stale screenshot. BUG=160668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177074

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	content/browser/web_contents/navigation_controller_impl.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download
	M	content/browser/web_contents/navigation_entry_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi! Sorry this change got lost between patchsets in https://codereview.chromium.org/11776010/

7 years, 11 months ago (2013-01-15 23:12:16 UTC) #1

lgtm

Expand Messages | Collapse Messages