Source/devtools/front_end/emulation/ResponsiveDesignView.js - Issue 1195793008: [DevTools] Implement screen orientation override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/emulation/ResponsiveDesignView.js

Issue 1195793008: [DevTools] Implement screen orientation override. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: error tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/emulation/OverridesSupport.js ('k') | Source/devtools/protocol.json » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/emulation/ResponsiveDesignView.js

diff --git a/Source/devtools/front_end/emulation/ResponsiveDesignView.js b/Source/devtools/front_end/emulation/ResponsiveDesignView.js

index 767643d148305a1964116063cdedbb6906d6e75e..b179d770def53f4225b38bbe781b1053e114ec57 100644

--- a/Source/devtools/front_end/emulation/ResponsiveDesignView.js

+++ b/Source/devtools/front_end/emulation/ResponsiveDesignView.js

@@ -734,8 +734,10 @@ WebInspector.ResponsiveDesignView.prototype = {

if (device && mode) {

var orientation = device.orientationByName(mode.orientation);

this._deviceInsets = mode.insets;

+ WebInspector.overridesSupport.settings.screenOrientationOverride.set(mode.orientation == WebInspector.EmulatedDevice.Horizontal ? "landscapePrimary" : "portraitPrimary");

} else {

this._deviceInsets = new Insets(0, 0, 0, 0);

+ WebInspector.overridesSupport.settings.screenOrientationOverride.set("");

}

this.dispatchEventToListeners(WebInspector.OverridesSupport.PageResizer.Events.InsetsChanged, this._deviceInsets);