Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1195793002: MIPS: Implemented PC-relative instructions for R6. (Closed)

Created:
5 years, 6 months ago by Ilija.Pavlovic1
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Implemented PC-relative instructions for R6. Added: JIC, BEQZC, JIALC, LDPC, LWPC, ALUIPC, ADDIUPC, ALIGN/DAILGN, LWUPC, AUIPC, BC, BALC. Additional fixed compact branch offset. TEST=test-assembler-mips[64]/r6_align, r6_dalign, r6_aluipc, r6_lwpc, r6_jic, r6_beqzc, r6_jialc, r6_addiupc, r6_ldpc, r6_lwupc, r6_auipc, r6_bc, r6_balc BUG= Committed: https://crrev.com/f0c4edfdc5ed28258881b683424c672c39b266b3 Cr-Commit-Position: refs/heads/master@{#29143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3179 lines, -320 lines) Patch
M src/mips/assembler-mips.h View 5 chunks +17 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 8 chunks +83 lines, -24 lines 0 comments Download
M src/mips/constants-mips.h View 8 chunks +103 lines, -57 lines 0 comments Download
M src/mips/constants-mips.cc View 5 chunks +30 lines, -3 lines 0 comments Download
M src/mips/disasm-mips.cc View 11 chunks +226 lines, -32 lines 0 comments Download
M src/mips/simulator-mips.cc View 8 chunks +141 lines, -24 lines 0 comments Download
M src/mips64/assembler-mips64.h View 5 chunks +20 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 10 chunks +108 lines, -25 lines 0 comments Download
M src/mips64/constants-mips64.h View 8 chunks +130 lines, -72 lines 0 comments Download
M src/mips64/constants-mips64.cc View 5 chunks +48 lines, -4 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 10 chunks +253 lines, -31 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 11 chunks +235 lines, -37 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 2 chunks +705 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 2 chunks +915 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 4 chunks +71 lines, -7 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +94 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ilija.Pavlovic1
This time with right credentials.
5 years, 6 months ago (2015-06-19 10:39:54 UTC) #2
dusmil.imgtec
LGTM.
5 years, 6 months ago (2015-06-19 10:40:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195793002/1
5 years, 6 months ago (2015-06-19 10:40:55 UTC) #5
commit-bot: I haz the power
The author Ilija.Pavlovic@imgtec.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-19 10:40:57 UTC) #6
commit-bot: I haz the power
The author Ilija.Pavlovic@imgtec.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-19 11:00:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 11:06:05 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 11:06:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0c4edfdc5ed28258881b683424c672c39b266b3
Cr-Commit-Position: refs/heads/master@{#29143}

Powered by Google App Engine
This is Rietveld 408576698