Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1195763002: Cleanup: Remove experimental V8 cache strategies that we discarded. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add #if-guard for multi-CL change. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/DEPS ('k') | Source/bindings/core/v8/V8CacheOptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/ScriptStreamer.h" 6 #include "bindings/core/v8/ScriptStreamer.h"
7 7
8 #include "bindings/core/v8/ScriptStreamerThread.h" 8 #include "bindings/core/v8/ScriptStreamerThread.h"
9 #include "bindings/core/v8/V8ScriptRunner.h" 9 #include "bindings/core/v8/V8ScriptRunner.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 // downloads. 630 // downloads.
631 631
632 if (!scriptState->contextIsValid()) { 632 if (!scriptState->contextIsValid()) {
633 Platform::current()->histogramEnumeration(notStreamingReasonHistogramNam e(scriptType), ContextNotValid, NotStreamingReasonEnd); 633 Platform::current()->histogramEnumeration(notStreamingReasonHistogramNam e(scriptType), ContextNotValid, NotStreamingReasonEnd);
634 return false; 634 return false;
635 } 635 }
636 636
637 // Decide what kind of cached data we should produce while streaming. Only 637 // Decide what kind of cached data we should produce while streaming. Only
638 // produce parser cache if the non-streaming compile takes advantage of it. 638 // produce parser cache if the non-streaming compile takes advantage of it.
639 v8::ScriptCompiler::CompileOptions compileOption = v8::ScriptCompiler::kNoCo mpileOptions; 639 v8::ScriptCompiler::CompileOptions compileOption = v8::ScriptCompiler::kNoCo mpileOptions;
640 if (settings->v8CacheOptions() == V8CacheOptionsParseMemory || settings->v8C acheOptions() == V8CacheOptionsParse) 640 if (settings->v8CacheOptions() == V8CacheOptionsParse)
641 compileOption = v8::ScriptCompiler::kProduceParserCache; 641 compileOption = v8::ScriptCompiler::kProduceParserCache;
642 642
643 // The Resource might go out of scope if the script is no longer 643 // The Resource might go out of scope if the script is no longer
644 // needed. This makes PendingScript notify the ScriptStreamer when it is 644 // needed. This makes PendingScript notify the ScriptStreamer when it is
645 // destroyed. 645 // destroyed.
646 script.setStreamer(ScriptStreamer::create(resource, scriptType, scriptState, compileOption)); 646 script.setStreamer(ScriptStreamer::create(resource, scriptType, scriptState, compileOption));
647 647
648 return true; 648 return true;
649 } 649 }
650 650
651 } // namespace blink 651 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/DEPS ('k') | Source/bindings/core/v8/V8CacheOptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698