Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1195693003: Revert of [release-tools] Fix possible race condition in retrieval of latest rolled version (Closed)

Created:
5 years, 6 months ago by Michael Hablich
Modified:
5 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [release-tools] Fix possible race condition in retrieval of latest rolled version (patchset #2 id:20001 of https://codereview.chromium.org/1186393007/) Reason for revert: Build slave fetches git repo from cache not from real repo. Original issue's description: > [release-tools] Fix possible race condition in retrieval of latest rolled version > > R=machenbach@chromium.org > BUG= > NOTRY=true > > Committed: https://crrev.com/5d2a85b2450f9f88a94949052c5b055c1304b9b8 > Cr-Commit-Position: refs/heads/master@{#29137} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/29c575bc7e8b896d566599419e6f73ec349b30fe Cr-Commit-Position: refs/heads/master@{#29140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/release/auto_roll.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/release/test_scripts.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of [release-tools] Fix possible race condition in retrieval of latest rolled version
5 years, 6 months ago (2015-06-19 09:32:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195693003/1
5 years, 6 months ago (2015-06-19 09:32:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 09:32:41 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 09:33:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29c575bc7e8b896d566599419e6f73ec349b30fe
Cr-Commit-Position: refs/heads/master@{#29140}

Powered by Google App Engine
This is Rietveld 408576698