Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: media/base/audio_bus.cc

Issue 1195633003: Add a silent audio sink to consume WebAudio data on silence detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify the CL to use NullAudioSink Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_bus.cc
diff --git a/media/base/audio_bus.cc b/media/base/audio_bus.cc
index 719dbcd55714c941b5d61f2c13cb56f40269ce2b..488ebe4e39a6fedcd88293ce0964e0570fe9056b 100644
--- a/media/base/audio_bus.cc
+++ b/media/base/audio_bus.cc
@@ -218,6 +218,19 @@ void AudioBus::Zero() {
ZeroFrames(frames_);
}
+bool AudioBus::AreFramesZero() const {
+ if (frames_ <= 0)
DaleCurtis 2015/06/22 19:14:41 Seems unnecessary, loop will exit quickly anyway.
qinmin 2015/06/22 22:23:16 Done.
+ return true;
+
+ for (size_t i = 0; i < channel_data_.size(); ++i) {
+ for (int j = 0; j < frames_; j++) {
+ if (*(channel_data_[i] + j) != 0.0f)
DaleCurtis 2015/06/22 19:14:41 Just use "if (channel_data_[i][j]) return false;"
qinmin 2015/06/22 22:23:16 Done.
+ return false;
+ }
+ }
+ return true;
+}
+
int AudioBus::CalculateMemorySize(const AudioParameters& params) {
return CalculateMemorySizeInternal(
params.channels(), params.frames_per_buffer(), NULL);

Powered by Google App Engine
This is Rietveld 408576698