Introduce IBusBridge for ibus-less implementation.

Introduce IBusBridge for ibus-less implementation.

IBusBridge provides access of each ibus event handler.

BUG=170671
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179842

[satorux1, 2013-01-17 20:43:30]

https://codereview.chromium.org/11956041/diff/6001/chromeos/ime/ibus_bridge.h
File chromeos/ime/ibus_bridge.h (right):

https://codereview.chromium.org/11956041/diff/6001/chromeos/ime/ibus_bridge.h...
chromeos/ime/ibus_bridge.h:21: // by TLS because IME related stuff should be
accessible only from UI thread.
I'm confused. Why TLS? If this is only accessible from one thread, why not just
use a global variable in anonymous namespace in .cc file?

[Seigo Nonaka, 2013-01-18 06:05:59]

https://codereview.chromium.org/11956041/diff/6001/chromeos/ime/ibus_bridge.h
File chromeos/ime/ibus_bridge.h (right):

https://codereview.chromium.org/11956041/diff/6001/chromeos/ime/ibus_bridge.h...
chromeos/ime/ibus_bridge.h:21: // by TLS because IME related stuff should be
accessible only from UI thread.
I don't have strong opinion for TLS.
I just don't want IBusBridge to be used without UI thread.

I changed Singleton instead of TLS or global variable, because IBusBridge does
not need special initialization and it can be done at any time.

On 2013/01/17 20:43:31, satorux1 wrote:
> I'm confused. Why TLS? If this is only accessible from one thread, why not
just
> use a global variable in anonymous namespace in .cc file?

[satorux1, 2013-01-29 05:18:56]

https://codereview.chromium.org/11956041/diff/9001/chromeos/ime/ibus_bridge.h
File chromeos/ime/ibus_bridge.h (right):

https://codereview.chromium.org/11956041/diff/9001/chromeos/ime/ibus_bridge.h...
chromeos/ime/ibus_bridge.h:22: // as singleton object.
Please describe this class more carefully. Why do we need this? What problems
are we solving with this class?

[Seigo Nonaka, 2013-01-30 06:21:54]

https://codereview.chromium.org/11956041/diff/9001/chromeos/ime/ibus_bridge.h
File chromeos/ime/ibus_bridge.h (right):

https://codereview.chromium.org/11956041/diff/9001/chromeos/ime/ibus_bridge.h...
chromeos/ime/ibus_bridge.h:22: // as singleton object.
Sorry, I update class comment.
On 2013/01/29 05:18:56, satorux1 wrote:
> Please describe this class more carefully. Why do we need this? What problems
> are we solving with this class?

[satorux1, 2013-01-31 01:39:08]

LGTM

[commit-bot: I haz the power, 2013-01-31 03:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11956041/16001

[commit-bot: I haz the power, 2013-01-31 03:43:12]

Failed to apply patch for chromeos/chromeos.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chromeos/chromeos.gyp
  Hunk #1 FAILED at 123.
  1 out of 1 hunk FAILED -- saving rejects to file chromeos/chromeos.gyp.rej

Patch:       chromeos/chromeos.gyp
Index: chromeos/chromeos.gyp
diff --git a/chromeos/chromeos.gyp b/chromeos/chromeos.gyp
index
a3dc3de3b29b62647d29ca0146e8b4decf306109..c999052ec3f630e3629b9b0972bff1c3c76d1a27
100644
--- a/chromeos/chromeos.gyp
+++ b/chromeos/chromeos.gyp
@@ -123,6 +123,8 @@
         'disks/disk_mount_manager.h',
         'display/output_configurator.cc',
         'display/output_configurator.h',
+        'ime/ibus_bridge.h',
+        'ime/ibus_bridge.cc',
         'network/cros_network_functions.cc',
         'network/cros_network_functions.h',
         'network/device_state.cc',

[commit-bot: I haz the power, 2013-01-31 03:56:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11956041/22002

[commit-bot: I haz the power, 2013-01-31 10:23:57]

Change committed as 179842