content/browser/browser_plugin/browser_plugin_embedder.h - Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Istiaque's comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_plugin/browser_plugin_embedder.h

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h

index b91837032e24af95b50519a54b3c485a417eaa70..7f336d5ffeec4f32b74a703a39ed7839eb2a8818 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.h

+++ b/content/browser/browser_plugin/browser_plugin_embedder.h

@@ -118,6 +118,7 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver,

// Message handlers.

+ void OnAllocateInstanceID(int request_id);

void OnCreateGuest(int instance_id,

const BrowserPluginHostMsg_CreateGuest_Params& params);

void OnPluginAtPositionResponse(int instance_id,

@@ -148,6 +149,7 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver,

GetRenderViewHostCallbackMap pending_get_render_view_callbacks_;

// Next request id for BrowserPluginMsg_PluginAtPositionRequest query.

int next_get_render_view_request_id_;

+ int instance_id_counter_;

Charlie Reis 2013/01/18 01:54:31 Should we be more consistent with the name above,

Fady Samuel 2013/01/18 02:23:10 Done.

DISALLOW_COPY_AND_ASSIGN(BrowserPluginEmbedder);

};

« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('J')