content/renderer/browser_plugin/browser_plugin_manager.h - Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.h

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Diff against simplified focus Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/browser_plugin/browser_plugin.cc ('K') | « content/renderer/browser_plugin/browser_plugin_browsertest.cc ('k') | content/renderer/browser_plugin/browser_plugin_manager.cc » ('j') | content/renderer/browser_plugin/browser_plugin_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin_manager.h

diff --git a/content/renderer/browser_plugin/browser_plugin_manager.h b/content/renderer/browser_plugin/browser_plugin_manager.h

index 21f17fa1033771a4e5f2cf1775bf354bdd277a19..c2bcda7918e72198841f0c6f2d33c0f372ba0898 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager.h

+++ b/content/renderer/browser_plugin/browser_plugin_manager.h

@@ -48,6 +48,7 @@ class CONTENT_EXPORT BrowserPluginManager

RenderViewImpl* render_view,

WebKit::WebFrame* frame,

const WebKit::WebPluginParams& params) = 0;

+ virtual void AllocateInstanceID(BrowserPlugin* browser_plugin) = 0;

void AddBrowserPlugin(int instance_id, BrowserPlugin* browser_plugin);

void RemoveBrowserPlugin(int instance_id);

@@ -76,7 +77,8 @@ class CONTENT_EXPORT BrowserPluginManager

virtual ~BrowserPluginManager();

IDMap<BrowserPlugin> instances_;

base::WeakPtr<RenderViewImpl> render_view_;

- int browser_plugin_counter_;

+ DISALLOW_COPY_AND_ASSIGN(BrowserPluginManager);

};

} // namespace content