Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager

content/browser/browser_plugin/browser_plugin_embedder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A BrowserPluginEmbedder has a list of guests it manages.
 // In the beginning when a renderer sees one or more guests (BrowserPlugin
 // instance(s)) and there is a request to navigate to them, the WebContents for
 // that renderer creates a BrowserPluginEmbedder for itself. The
 // BrowserPluginEmbedder, in turn, manages a set of BrowserPluginGuests -- one
 // BrowserPluginGuest for each guest in the embedding WebContents. Note that
@@ skipping 42 matching lines @@
   typedef std::map<int, WebContents*> ContainerInstanceMap;
 
   virtual ~BrowserPluginEmbedder();
 
   static BrowserPluginEmbedder* Create(WebContentsImpl* web_contents,
                                        RenderViewHost* render_view_host);
 
   // Create a guest WebContents with the provided |instance_id| and |params| and
   // add it to this BrowserPluginEmbedder. Optionally, the new guest may be
   // attached to a |guest_opener|, and may be attached to a pre-selected
   // |routing_id|.

[Charlie Reis, 2013/01/18 05:36:45]

Please update this comment to say that it does the navigation as well if
params.src is present.  (I think that got missed in my last round of comments.)

[Fady Samuel, 2013/01/18 15:26:25]

Done.

   void CreateGuest(int instance_id,
                    int routing_id,
                    BrowserPluginGuest* guest_opener,
                    const BrowserPluginHostMsg_CreateGuest_Params& params);
 
   // Returns a guest browser plugin delegate by its container ID specified
   // in BrowserPlugin.
   BrowserPluginGuest* GetGuestByInstanceID(int instance_id) const;
 
   // Destroy the guest with the provided |instance_id|. Remove references to the
@@ skipping 37 matching lines @@
   void CleanUp();
 
   // Called when visiblity of web_contents changes, so the embedder will
   // show/hide its guest.
   void WebContentsVisibilityChanged(bool visible);
 
   static bool ShouldForwardToBrowserPluginGuest(const IPC::Message& message);
 
   // Message handlers.
 
+  void OnAllocateInstanceID(int request_id);
   void OnCreateGuest(int instance_id,
                      const BrowserPluginHostMsg_CreateGuest_Params& params);
   void OnPluginAtPositionResponse(int instance_id,
                                   int request_id,
                                   const gfx::Point& position);
   void OnPluginDestroyed(int instance_id);
   void OnSwapBuffersACK(int route_id,
                         int gpu_host_id,
                         const std::string& mailbox_name,
                         uint32 sync_point);
@@ skipping 10 matching lines @@
   // Tracks the visibility state of the embedder.
   bool visible_;
   // Map that contains outstanding queries to |GetBrowserPluginAt|.
   // We need a roundtrip to renderer process to know the answer, therefore
   // storing these callbacks is required.
   typedef std::map<int, WebContents::GetRenderViewHostCallback>
       GetRenderViewHostCallbackMap;
   GetRenderViewHostCallbackMap pending_get_render_view_callbacks_;
   // Next request id for BrowserPluginMsg_PluginAtPositionRequest query.
   int next_get_render_view_request_id_;
+  int next_instance_id_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginEmbedder);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_EMBEDDER_H_