Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: ui/base/ime/input_method_ibus_unittest.cc

Issue 11956008: Move SetCursorLocation bypass code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unittests: add TextInputTestSupport initialzation Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_ibus.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_ibus_unittest.cc
diff --git a/ui/base/ime/input_method_ibus_unittest.cc b/ui/base/ime/input_method_ibus_unittest.cc
index f79777d76c1575c3c226f16580a50f642c2a41d2..e10ba4d404244dd9df11f09d7bec3c14552d230d 100644
--- a/ui/base/ime/input_method_ibus_unittest.cc
+++ b/ui/base/ime/input_method_ibus_unittest.cc
@@ -810,9 +810,7 @@ TEST_F(InputMethodIBusTest, FocusIn_Text) {
EXPECT_EQ(1, mock_ibus_client_->create_input_context_call_count());
// Since a form has focus, IBusClient::FocusIn() should be called.
EXPECT_EQ(1, mock_ibus_input_context_client_->focus_in_call_count());
- // TODO(nona): Change following expectation to 1 once new bypass
- // implementation is landed.
- EXPECT_EQ(0,
+ EXPECT_EQ(1,
mock_ibus_input_context_client_->set_cursor_location_call_count());
// ui::TextInputClient::OnInputMethodChanged() should be called when
// ui::InputMethodIBus connects/disconnects to/from ibus-daemon and the
@@ -883,9 +881,7 @@ TEST_F(InputMethodIBusTest, FocusOut_Url) {
}
// Test if the new |caret_bounds_| is correctly sent to ibus-daemon.
-// TODO(nona): Re-enable following tests once new bypas implementation is
-// land.
-TEST_F(InputMethodIBusTest, DISABLED_OnCaretBoundsChanged) {
+TEST_F(InputMethodIBusTest, OnCaretBoundsChanged) {
SetCreateContextSuccessHandler();
chromeos::DBusThreadManager::Get()->InitIBusBus("dummy address");
input_type_ = TEXT_INPUT_TYPE_TEXT;
@@ -1180,6 +1176,7 @@ class InputMethodIBusKeyEventTest : public InputMethodIBusTest {
chromeos::DBusThreadManager::Get()->InitIBusBus("dummy address");
ime_->Init(true);
ime_->OnConnected();
+ mock_ibus_input_context_client_->SetIsXKBLayout(false);
}
DISALLOW_COPY_AND_ASSIGN(InputMethodIBusKeyEventTest);
« no previous file with comments | « ui/base/ime/input_method_ibus.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698