Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11956004: Fix vm code base so that it can be built for --arch=simarm (no snapshot yet). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 17110)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -1311,9 +1311,14 @@
}
if ((recognized_kind == MethodRecognizer::kDoubleTruncate) ||
(recognized_kind == MethodRecognizer::kDoubleRound)) {
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
srdjan 2013/01/16 19:06:30 Instead of ifdef, use a shared e.g., SuportsDoubl
regis 2013/01/16 23:14:42 As soon as we implement the arm version, there wil
srdjan 2013/01/16 23:57:56 I think that the optimizer will remain machine ind
regis 2013/01/17 01:02:07 Alright. I have added a double_truncate_round_supp
+ // TODO(regis): FlowGraphOptimizer should be architecture dependent.
if (!CPUFeatures::sse4_1_supported()) {
return false;
}
+#else
+ return false;
+#endif
AddCheckClass(call, call->ArgumentAt(0)->value()->Copy());
DoubleToDoubleInstr* d2d_instr =
new DoubleToDoubleInstr(call->ArgumentAt(0)->value(),

Powered by Google App Engine
This is Rietveld 408576698