Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: runtime/vm/assembler_ia32.h

Issue 11956004: Fix vm code base so that it can be built for --arch=simarm (no snapshot yet). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_ia32.h
===================================================================
--- runtime/vm/assembler_ia32.h (revision 17107)
+++ runtime/vm/assembler_ia32.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -30,9 +30,7 @@
private:
const int32_t value_;
-
- // TODO(5411081): Add DISALLOW_COPY_AND_ASSIGN(Immediate) once the mac
- // build issue is resolved.
+ DISALLOW_ALLOCATION();
};
@@ -116,9 +114,7 @@
}
friend class Assembler;
-
- // TODO(5411081): Add DISALLOW_COPY_AND_ASSIGN(Operand) once the mac
- // build issue is resolved.
+ DISALLOW_ALLOCATION();
};
@@ -171,9 +167,7 @@
private:
Address() {}
-
- // TODO(5411081): Add DISALLOW_COPY_AND_ASSIGN(Address) once the mac
- // build issue is resolved.
+ DISALLOW_ALLOCATION();
};
@@ -636,7 +630,7 @@
const Code::Comments& GetCodeComments() const;
static const char* RegisterName(Register reg);
- static const char* XmmRegisterName(XmmRegister reg);
+ static const char* FpuRegisterName(XmmRegister reg);
Ivan Posva 2013/01/16 01:17:56 This looks very asymmetric. Either it should take
regis 2013/01/16 01:55:07 Renamed parameter type.
private:
AssemblerBuffer buffer_;

Powered by Google App Engine
This is Rietveld 408576698