Fix vm code base so that it can be built for --arch=simarm (no snapshot yet).

runtime/vm/allocation.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ALLOCATION_H_
 #define VM_ALLOCATION_H_
 
 #include "platform/assert.h"
 #include "vm/base_isolate.h"
 #include "vm/globals.h"
 
 namespace dart {
 
 // Forward declarations.
 class Isolate;
 
 // Stack allocated objects subclass from this base class. Objects of this type
 // cannot be allocated on either the C or object heaps. Destructors for objects
 // of this type will not be run unless the stack is unwound through normal
 // program control flow.
 class ValueObject {
  public:
   ValueObject() { }
   ~ValueObject() { }
 
  private:
-  DISALLOW_ALLOCATION();
-  // TODO(5411081): Add DISALLOW_COPY_AND_ASSIGN(ValueObject) once the mac
-  // build issue is resolved.
+  DISALLOW_COPY_AND_ASSIGN(ValueObject);

[Kevin Millikin (Google), 2013/02/04 11:15:03]

It seems strange and not useful that ValueObject is the base class of objects
that *can't* be passed by value.

[regis, 2013/02/04 16:41:45]

Objects deriving from ValueObject *can* be passed by value, but we want them to
declare their own copy constructor and assignment operator to make it clear.
As you can see by the number of patches (you are actually commenting on an older
patch :-) there was a lot of discussions here on what is the best style. The
compiler on the Mac is also buggy and difficult to please. We may revisit this
at some time.

 };
 
 
 // Stack resources subclass from this base class. The VM will ensure that the
 // destructors of these objects are called before the stack is unwound past the
 // objects location on the stack. Use stack resource objects if objects
 // need to be destroyed even in the case of exceptions when a Longjump is done
 // to a stack frame above the frame where these objects were allocated.
 class StackResource {
  public:
@@ skipping 69 matching lines @@
   // deallocated by invoking DeleteAll() on the zone they live in.
   void operator delete(void* pointer) { UNREACHABLE(); }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ZoneAllocated);
 };
 
 }  // namespace dart
 
 #endif  // VM_ALLOCATION_H_